Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Issue 691453002: Remove a lot of Widget APIs. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove a lot of Widget APIs. We don't need a lot of the Widget API. I also removed the visibility code which seems to have been broken when we removed FrameView::show and hide(), which looks like it would have broken image loading. Unfortuantely we don't have pixel tests or tests that load images so I can't test this yet. Even so it's a good simplificatin since our system has no concept of hidden widgets. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/211019e18c87ef47ad1708cce20cf66951118a40

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -78 lines) Patch
M sky/engine/core/frame/FrameView.h View 1 chunk +3 lines, -4 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +2 lines, -6 lines 1 comment Download
M sky/engine/platform/Widget.h View 3 chunks +2 lines, -24 lines 0 comments Download
M sky/engine/platform/Widget.cpp View 4 chunks +1 line, -39 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years, 1 month ago (2014-10-29 09:15:31 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/691453002/diff/1/sky/engine/core/rendering/RenderObject.cpp File sky/engine/core/rendering/RenderObject.cpp (right): https://codereview.chromium.org/691453002/diff/1/sky/engine/core/rendering/RenderObject.cpp#newcode2572 sky/engine/core/rendering/RenderObject.cpp:2572: return !document().activeDOMObjectsAreSuspended(); active DOM object cannot ever be ...
6 years, 1 month ago (2014-10-29 16:49:17 UTC) #3
esprehn
6 years, 1 month ago (2014-10-29 22:23:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
211019e18c87ef47ad1708cce20cf66951118a40.

Powered by Google App Engine
This is Rietveld 408576698