Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 69143003: [Mac] Fix title text re-expanding after tab media indicator shuts off. (Closed)

Created:
7 years, 1 month ago by miu
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Fix title text re-expanding after tab media indicator shuts off. TabController needs to be notified to re-compute visibility and layout whenever a media indicator animation ends, to account for the case where the MediaIndicatorView should be hidden. A simple callback scheme has been added, rather than using NSView::setNeedsLayout, because TabController/TabView employ their own custom layout mechanism. BUG=317843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234704

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/tabs/media_indicator_view.h View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/ui/cocoa/tabs/media_indicator_view.mm View 2 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
miu
PTAL. Please expedite (bug fix for M32). Thanks, Yuri
7 years, 1 month ago (2013-11-11 22:51:52 UTC) #1
miu
On 2013/11/11 22:51:52, Yuri wrote: > PTAL. Please expedite (bug fix for M32). avi: Not ...
7 years, 1 month ago (2013-11-12 20:30:28 UTC) #2
Avi (use Gerrit)
I would prefer the callback to be a block (that's more Cocoa-ey) but I'm completely ...
7 years, 1 month ago (2013-11-12 20:38:46 UTC) #3
miu
On 2013/11/12 20:38:46, Avi wrote: > I would prefer the callback to be a block ...
7 years, 1 month ago (2013-11-12 20:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/69143003/1
7 years, 1 month ago (2013-11-12 20:57:33 UTC) #5
rohitrao (ping after 24h)
Sorry, I meant to redirect this to either Avi or Sail today, but I didn't ...
7 years, 1 month ago (2013-11-12 21:24:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/69143003/1
7 years, 1 month ago (2013-11-12 23:56:03 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 01:48:59 UTC) #8
Message was sent while issue was closed.
Change committed as 234704

Powered by Google App Engine
This is Rietveld 408576698