[Mac] Fix title text re-expanding after tab media indicator shuts off.

[Mac] Fix title text re-expanding after tab media indicator shuts off.

TabController needs to be notified to re-compute visibility and layout whenever a media indicator animation ends, to account for the case where the MediaIndicatorView should be hidden.  A simple callback scheme has been added, rather than using NSView::setNeedsLayout, because TabController/TabView employ their own custom layout mechanism.

BUG=317843
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234704

[miu, 2013-11-11 22:51:52]

PTAL.  Please expedite (bug fix for M32).

Thanks,
Yuri

[miu, 2013-11-12 20:30:28]

On 2013/11/11 22:51:52, Yuri wrote:
> PTAL.  Please expedite (bug fix for M32).

avi: Not sure whether rohitrao@ is available.  Can you PTAL?

[Avi (use Gerrit), 2013-11-12 20:38:46]

I would prefer the callback to be a block (that's more Cocoa-ey) but I'm
completely happy to say it LGTM as-is if you want to get this in.

https://codereview.chromium.org/69143003/diff/1/chrome/browser/ui/cocoa/tabs/...
File chrome/browser/ui/cocoa/tabs/media_indicator_view.h (right):

https://codereview.chromium.org/69143003/diff/1/chrome/browser/ui/cocoa/tabs/...
chrome/browser/ui/cocoa/tabs/media_indicator_view.h:38: -
(void)setAnimationDoneCallbackObject:(id)anObject withSelector:(SEL)selector;
Take a block?

[miu, 2013-11-12 20:52:57]

On 2013/11/12 20:38:46, Avi wrote:
> I would prefer the callback to be a block (that's more Cocoa-ey) but I'm
> completely happy to say it LGTM as-is if you want to get this in.

I suspected I should be using a block, but I haven't worked with them before and
am unsure about binding semantics, memory management issues, etc.  I didn't want
to risk messing anything up for something that's patching a near-stable branch. 
;-)  Since I'm going to be doing more work on this code in the coming months,
I'll revisit this as a clean-up task.

Thanks for the quick turnaround!  :)

[commit-bot: I haz the power, 2013-11-12 20:57:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/69143003/1

[rohitrao (ping after 24h), 2013-11-12 21:24:49]

Sorry, I meant to redirect this to either Avi or Sail today, but I didn't get a
chance to look up which would be a more appropriate reviewer.

I'm far enough removed from this code that it's better off in Avi's hands =)

[commit-bot: I haz the power, 2013-11-12 23:56:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/69143003/1

[commit-bot: I haz the power, 2013-11-13 01:48:59]

Change committed as 234704