content/browser/service_worker/service_worker_info.h - Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_info.h

Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_info.h

diff --git a/content/browser/service_worker/service_worker_info.h b/content/browser/service_worker/service_worker_info.h

index 6fc2eef1c5d46d6af93e1921228d901244a5565f..218d154c53ddce4cd9b4e6bc6e7c1a3d95772346 100644

--- a/content/browser/service_worker/service_worker_info.h

+++ b/content/browser/service_worker/service_worker_info.h

@@ -25,7 +25,6 @@ class CONTENT_EXPORT ServiceWorkerVersionInfo {

int devtools_agent_route_id);

~ServiceWorkerVersionInfo();

- bool is_null;

ServiceWorkerVersion::RunningStatus running_status;

ServiceWorkerVersion::Status status;

GURL script_url;