| Index: content/browser/service_worker/service_worker_registration_unittest.cc
|
| diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
|
| index 2adb68d32b97c43f502af41d2de7703f7450c353..d7d3de0c2cc5c79a81547ce3332ba07ed68cf455 100644
|
| --- a/content/browser/service_worker/service_worker_registration_unittest.cc
|
| +++ b/content/browser/service_worker/service_worker_registration_unittest.cc
|
| @@ -120,9 +120,9 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
|
| EXPECT_EQ(kScope, listener.observed_info_.pattern);
|
| EXPECT_EQ(version_1_id, listener.observed_info_.active_version.version_id);
|
| EXPECT_EQ(kScript, listener.observed_info_.active_version.script_url);
|
| - EXPECT_TRUE(listener.observed_info_.installing_version.is_null);
|
| - EXPECT_TRUE(listener.observed_info_.waiting_version.is_null);
|
| - EXPECT_TRUE(listener.observed_info_.controlling_version.is_null);
|
| + EXPECT_TRUE(listener.observed_info_.installing_version.version_id == kInvalidServiceWorkerVersionId);
|
| + EXPECT_TRUE(listener.observed_info_.waiting_version.version_id == kInvalidServiceWorkerVersionId);
|
| + EXPECT_TRUE(listener.observed_info_.controlling_version.version_id == kInvalidServiceWorkerVersionId);
|
| listener.Reset();
|
|
|
| registration->SetInstallingVersion(version_2.get());
|
| @@ -133,8 +133,8 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
|
| EXPECT_EQ(version_1_id, listener.observed_info_.active_version.version_id);
|
| EXPECT_EQ(version_2_id,
|
| listener.observed_info_.installing_version.version_id);
|
| - EXPECT_TRUE(listener.observed_info_.waiting_version.is_null);
|
| - EXPECT_TRUE(listener.observed_info_.controlling_version.is_null);
|
| + EXPECT_TRUE(listener.observed_info_.waiting_version.version_id == kInvalidServiceWorkerVersionId);
|
| + EXPECT_TRUE(listener.observed_info_.controlling_version.version_id == kInvalidServiceWorkerVersionId);
|
| listener.Reset();
|
|
|
| registration->SetWaitingVersion(version_2.get());
|
| @@ -145,8 +145,8 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
|
| EXPECT_TRUE(listener.observed_changed_mask_.installing_changed());
|
| EXPECT_EQ(version_1_id, listener.observed_info_.active_version.version_id);
|
| EXPECT_EQ(version_2_id, listener.observed_info_.waiting_version.version_id);
|
| - EXPECT_TRUE(listener.observed_info_.installing_version.is_null);
|
| - EXPECT_TRUE(listener.observed_info_.controlling_version.is_null);
|
| + EXPECT_TRUE(listener.observed_info_.installing_version.version_id == kInvalidServiceWorkerVersionId);
|
| + EXPECT_TRUE(listener.observed_info_.controlling_version.version_id == kInvalidServiceWorkerVersionId);
|
| listener.Reset();
|
|
|
| registration->UnsetVersion(version_2.get());
|
| @@ -155,9 +155,9 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
|
| EXPECT_EQ(ChangedVersionAttributesMask::WAITING_VERSION,
|
| listener.observed_changed_mask_.changed());
|
| EXPECT_EQ(version_1_id, listener.observed_info_.active_version.version_id);
|
| - EXPECT_TRUE(listener.observed_info_.waiting_version.is_null);
|
| - EXPECT_TRUE(listener.observed_info_.installing_version.is_null);
|
| - EXPECT_TRUE(listener.observed_info_.controlling_version.is_null);
|
| + EXPECT_TRUE(listener.observed_info_.waiting_version.version_id == kInvalidServiceWorkerVersionId);
|
| + EXPECT_TRUE(listener.observed_info_.installing_version.version_id == kInvalidServiceWorkerVersionId);
|
| + EXPECT_TRUE(listener.observed_info_.controlling_version.version_id == kInvalidServiceWorkerVersionId);
|
| }
|
|
|
| TEST_F(ServiceWorkerRegistrationTest, FailedRegistrationNoCrash) {
|
|
|