content/browser/service_worker/service_worker_browsertest.cc - Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index 01b1ffac45cf6032261da58e6adbbef7ca06b2f8..62b6341898dde152b5c165d49d9d8dc59f23caa1 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -242,11 +242,11 @@ void CountScriptResources(

int version_id;

size_t index = infos.size() - 1;

- if (!infos[index].installing_version.is_null)

+ if (infos[index].installing_version.version_id != kInvalidServiceWorkerVersionId)

nhiroki 2014/10/31 05:48:45 nit: You are not in Blink but in Chromium, so coul

Paritosh Kumar 2014/10/31 06:53:19 Done.

version_id = infos[index].installing_version.version_id;

- else if (!infos[index].waiting_version.is_null)

+ else if (infos[index].waiting_version.version_id != kInvalidServiceWorkerVersionId)

version_id = infos[1].waiting_version.version_id;

- else if (!infos[index].active_version.is_null)

+ else if (infos[index].active_version.version_id != kInvalidServiceWorkerVersionId)

version_id = infos[index].active_version.version_id;

else

return;

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_info.h » ('j') | content/browser/service_worker/service_worker_job_unittest.cc » ('J')