[Smart Lock] Expose the easy_unlock.proximity_required pref via the chrome.preferencesPrivate API.

[Smart Lock] Expose the easy_unlock.proximity_required pref via the chrome.preferencesPrivate API.

BUG=403419
TEST=none
R=tengs@chromium.org

Committed: https://crrev.com/d04216fc7f51a90440ffa7bcf6a492d7bddb187f
Cr-Commit-Position: refs/heads/master@{#302683}

[Tim Song, 2014-11-03 19:07:21]

LGTM.

Please also add the preferencesPrivate permission to the app's manifest.json.

Also, does chrome.preferencesPrivate have an event when any of these properties
change?

[Ilya Sherman, 2014-11-04 03:07:51]

On 2014/11/03 19:07:21, Tim Song wrote:
> LGTM.

Thanks.  I realized after sending this CL, though, that I also need to tweak the
API permissions to allow our app to see it... and I've been stuck on that, even
though it seems like it should be an easy syntactic change :/

> Please also add the preferencesPrivate permission to the app's manifest.json.

Yeah, I was going to do that in google3.  Is the manifest checked in to the
chromium repository?

> Also, does chrome.preferencesPrivate have an event when any of these
properties
> change?

It does, actually.  The "ChromeDirectSetting" type has a bunch of things defined
on it, including an onChange listener:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

[Ilya Sherman, 2014-11-04 03:23:05]

On 2014/11/04 03:07:51, Ilya Sherman wrote:
> On 2014/11/03 19:07:21, Tim Song wrote:
> > Please also add the preferencesPrivate permission to the app's
manifest.json.
> 
> Yeah, I was going to do that in google3.  Is the manifest checked in to the
> chromium repository?

Aha, I found the manifest, and updating it resolved the permissions issue that I
was hitting.  I didn't realize that we had this checked into the Chromium repo
-- good to know!

[Ilya Sherman, 2014-11-04 03:23:16]

isherman@chromium.org changed reviewers:
+ yoz@chromium.org

[Ilya Sherman, 2014-11-04 03:23:18]

+yoz for OWNERS approval

[Yoyo Zhou, 2014-11-04 19:54:25]

LGTM

[Tim Song, 2014-11-04 20:28:30]

Glad you found the manifest. The one in google3 doesn't actually do anything,
and is just a copy of the manifest in chromium.

This manifest is baked into the Chrome resources and used to audit component app
permissions.

[Ilya Sherman, 2014-11-04 20:55:11]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-11-04 20:57:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691393002/40001

[commit-bot: I haz the power, 2014-11-04 22:28:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 22:29:26]

Patchset 3 (id:??) landed as
https://crrev.com/d04216fc7f51a90440ffa7bcf6a492d7bddb187f
Cr-Commit-Position: refs/heads/master@{#302683}