Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 691383003: notice null colorfilter in legacy unflattening (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

notice null colorfilter in legacy unflattening BUG=skia:3117 Committed: https://skia.googlesource.com/skia/+/b969fc0f83528c26c6fdf1cbe8b45fb9a4d8a858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691383003/1
6 years, 1 month ago (2014-11-11 21:04:53 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-11 21:04:54 UTC) #4
Stephen White
Code looks ok. Unit test please?
6 years, 1 month ago (2014-11-11 21:08:01 UTC) #5
reed1
Not sure how, since the data that triggers is by definition built with an older ...
6 years, 1 month ago (2014-11-11 21:09:20 UTC) #6
Stephen White
Hmm. It does seem a bit worrying that we were creating SKPs with NULL colorfilters ...
6 years, 1 month ago (2014-11-11 21:12:03 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 21:13:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b969fc0f83528c26c6fdf1cbe8b45fb9a4d8a858

Powered by Google App Engine
This is Rietveld 408576698