Issue 691323002: Revert "Make the proxy server HostPortPair available in document_state so that"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 691323002: Revert "Make the proxy server HostPortPair available in document_state so that" (Closed)

Created:
6 years, 1 month ago by Mike Wittman

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Make the proxy server HostPortPair available in document_state so that" This reverts commit ac77ecc781ff1860e3344b99d6f5a8e9d672dd73. Speculative revert. ResourceDispatcherHostBrowserTest.CrossSiteNavigationErrorPage started flaking on Mac ASan and Mac ASan 64 following this change. BUG=374264 Committed: https://chromium.googlesource.com/chromium/src/+/e486fdebd3394cf9b5829263be5ecffca6185c3c

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -25 lines)			Patch
M	content/browser/loader/resource_loader.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/child/web_url_loader_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/child/weburlresponse_extradata_impl.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	content/common/resource_messages.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/resource_response.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/resource_response_info.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/public/renderer/document_state.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/e486fdebd3394cf9b5829263be5ecffca6185c3c Cr-Commit-Position: refs/heads/master@{#302207}

6 years, 1 month ago (2014-10-31 01:18:58 UTC) #1

Mike Wittman

6 years, 1 month ago (2014-10-31 01:19:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e486fdebd3394cf9b5829263be5ecffca6185c3c.

Expand Messages | Collapse Messages