Source/core/html/track/TextTrack.cpp - Issue 691313002: MSE: Implement TrackDefault object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrack.cpp

Issue 691313002: MSE: Implement TrackDefault object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Interim upload not ready for review. BIG TODO needs addressing. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrack.cpp

diff --git a/Source/core/html/track/TextTrack.cpp b/Source/core/html/track/TextTrack.cpp

index c653dff08cfa07febfe8fb840ca4ec940c297792..dc122b235931ef225e26469027b340298366cf2c 100644

--- a/Source/core/html/track/TextTrack.cpp

+++ b/Source/core/html/track/TextTrack.cpp

@@ -141,6 +141,22 @@ bool TextTrack::isValidKindKeyword(const AtomicString& value)

return false;

}

+bool TextTrack::isValidKindKeyword(const String& value)

+ if (value == subtitlesKeyword())

+ return true;

+ if (value == captionsKeyword())

+ return true;

+ if (value == descriptionsKeyword())

+ return true;

+ if (value == chaptersKeyword())

+ return true;

+ if (value == metadataKeyword())

+ return true;

+ return false;

void TextTrack::setTrackList(TextTrackList* trackList)

{

if (!trackList && mediaElement() && m_cues)