Source/core/html/track/VideoTrack.cpp - Issue 691313002: MSE: Implement TrackDefault object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/VideoTrack.cpp

Issue 691313002: MSE: Implement TrackDefault object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address (most of) philipj@'s PS7 comments and add one more test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/VideoTrack.cpp

diff --git a/Source/core/html/track/VideoTrack.cpp b/Source/core/html/track/VideoTrack.cpp

index 86d26b57cf077973b8ab39a406cdc856d6914768..12bb0f28bc70e087562e212bf57edefa8a67c2e2 100644

--- a/Source/core/html/track/VideoTrack.cpp

+++ b/Source/core/html/track/VideoTrack.cpp

@@ -69,14 +69,15 @@ const AtomicString& VideoTrack::commentaryKeyword()

return keyword;

}

-bool VideoTrack::isValidKind(const AtomicString& kind) const

+bool VideoTrack::isValidKindKeyword(const String& kind)

{

return (kind == alternativeKeyword())

|| (kind == captionsKeyword())

|| (kind == mainKeyword())

|| (kind == signKeyword())

|| (kind == subtitlesKeyword())

- || (kind == commentaryKeyword());

+ || (kind == commentaryKeyword())

+ || (kind == emptyAtom);

}

AtomicString VideoTrack::defaultKind() const