MSE: Implement TrackDefault object

Source/core/html/track/VideoTrack.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/html/track/VideoTrack.h"
 
 #include "core/html/HTMLMediaElement.h"
 
 namespace blink {
@@ skipping 51 matching lines @@
     DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("subtitles", AtomicString::ConstructFromLiteral));
     return keyword;
 }
 
 const AtomicString& VideoTrack::commentaryKeyword()
 {
     DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("commentary", AtomicString::ConstructFromLiteral));
     return keyword;
 }
 
-bool VideoTrack::isValidKind(const AtomicString& kind) const
+bool VideoTrack::isValidKindKeyword(const AtomicString& kind)
 {
     return (kind == alternativeKeyword())
         || (kind == captionsKeyword())
         || (kind == mainKeyword())
         || (kind == signKeyword())
         || (kind == subtitlesKeyword())
-        || (kind == commentaryKeyword());
+        || (kind == commentaryKeyword())
+        || (kind == emptyAtom);
+}
+
+bool VideoTrack::isValidKindKeyword(const String& kind)

[philipj_slow, 2014/11/14 12:03:37]

AtomicString is free to convert to String (and has an implicit cast operator) so
only the String variant is needed. (I hope, I only tested the AudioTrack case.)

[wolenetz, 2014/11/17 21:51:07]

Done.

+{
+    return (kind == alternativeKeyword())
+        || (kind == captionsKeyword())
+        || (kind == mainKeyword())
+        || (kind == signKeyword())
+        || (kind == subtitlesKeyword())
+        || (kind == commentaryKeyword())
+        || (kind == emptyAtom);
 }
 
 AtomicString VideoTrack::defaultKind() const
 {
     return emptyAtom;
 }
 
 }