Chromium-for-ChromiumOS/Linux compile-only trybots

Chromium-for-ChromiumOS/Linux compile-only trybots

Defined a compile-only try builder for Chromium-for-ChromiumOS/Linux release and
debug. Added these build configurations to the base Linux try builder pool.

BUG=429025
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292781

[dnj, 2014-10-30 23:52:43]

dnj@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, sergeyberezin@chromium.org

[dnj, 2014-10-30 23:52:43]

PTAL

[Sergey Berezin, 2014-10-31 00:59:30]

LGTM, but I'd also wait for Pawel's approval.

[Paweł Hajdan Jr., 2014-10-31 10:03:51]

Some comments, thanks for doing the patch, Dan!

Please let me know if you have questions about the new architecture
(based_on_main_waterfall). I'd strongly prefer all newly added bots to use it,
since it guarantees they will stay in sync with main waterfall.

https://codereview.chromium.org/691293002/diff/1/masters/master.tryserver.chr...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/691293002/diff/1/masters/master.tryserver.chr...
masters/master.tryserver.chromium.linux/master.cfg:645: 'build_config':
('Release' if 'rel' in targ else 'Debug'),
Please remove this dict, it's no-op.

https://codereview.chromium.org/691293002/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/691293002/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:155:
'linux_chromium_chromeos_compile_dbg': {
Please use base_on_main_waterfall infrastructure here, see other examples in
this file.

Also add _ng suffix to builder names.

[dnj, 2014-10-31 16:49:50]

https://codereview.chromium.org/691293002/diff/1/masters/master.tryserver.chr...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/691293002/diff/1/masters/master.tryserver.chr...
masters/master.tryserver.chromium.linux/master.cfg:645: 'build_config':
('Release' if 'rel' in targ else 'Debug'),
On 2014/10/31 10:03:50, Paweł Hajdan Jr. wrote:
> Please remove this dict, it's no-op.

Done. I'll remove it from the full build configuration above, too.

https://codereview.chromium.org/691293002/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/691293002/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:155:
'linux_chromium_chromeos_compile_dbg': {
On 2014/10/31 10:03:50, Paweł Hajdan Jr. wrote:
> Please use base_on_main_waterfall infrastructure here, see other examples in
> this file.
> 
> Also add _ng suffix to builder names.

Done. That's a great addition!

[Paweł Hajdan Jr., 2014-10-31 20:53:34]

LGTM!

[dnj, 2014-10-31 20:55:29]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2014-10-31 20:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691293002/20001

[commit-bot: I haz the power, 2014-10-31 20:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 20:56:44]

Failed to apply patch for
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A        
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
  Copied
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json
->
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
  patching file
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
  Hunk #2 FAILED at 99.
  Hunk #5 FAILED at 201.
  2 out of 5 hunks FAILED -- saving rejects to file
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json.rej

Patch:   NR 
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json->build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
Index:
scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
diff --git
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
similarity index 91%
copy from
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json
copy to
build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
index
896fe36a9661245d6c412e8c4a57ef010fdb8c19..fddbf2232021e60c24d8400fbfb5401f7959d15f
100644
---
a/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json
+++
b/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
@@ -7,7 +7,7 @@
       "--master",
       "tryserver.chromium.linux",
       "--builder",
-      "linux_chromium_rel_ng",
+      "linux_chromium_chromeos_compile_dbg_ng",
       "--slave",
       "TestSlavename",
       "--spec",
@@ -99,7 +99,7 @@
       "runhooks"
     ],
     "env": {
-      "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1
gomadir='[BUILD]/goma' target_arch=x64 test_isolation_mode=archive
test_isolation_outdir=https://isolateserver.appspot.com use_goma=1"
+      "GYP_DEFINES": "chromeos=1 component=shared_library dcheck_always_on=1
fastbuild=1 ffmpeg_branding=ChromeOS gomadir='[BUILD]/goma' proprietary_codecs=1
target_arch=x64 test_isolation_mode=archive
test_isolation_outdir=https://isolateserver.appspot.com use_goma=1"
     },
     "name": "gclient runhooks (with patch)"
   },
@@ -108,12 +108,12 @@
       "python",
       "-u",
       "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
-      "[SLAVE_BUILD]/src/testing/buildbot/chromium.linux.json",
+      "[SLAVE_BUILD]/src/testing/buildbot/chromium.chromiumos.json",
       "/path/to/tmp/json"
     ],
     "name": "read test spec",
     "~followup_annotations": [
-      "@@@STEP_TEXT@path:
[SLAVE_BUILD]/src/testing/buildbot/chromium.linux.json@@@",
+      "@@@STEP_TEXT@path:
[SLAVE_BUILD]/src/testing/buildbot/chromium.chromiumos.json@@@",
       "@@@STEP_LOG_LINE@json.output@{}@@@",
       "@@@STEP_LOG_END@json.output@@@"
     ]
@@ -127,11 +127,11 @@
       "/path/to/tmp/json",
       "--",
       "--build-config-fs",
-      "Release",
+      "Debug",
       "--paths",
       "{\"build\": \"[BUILD]\"}",
       "--properties",
-      "{\"buildername\": \"linux_chromium_rel_ng\", \"buildnumber\": 571,
\"slavename\": \"TestSlavename\"}"
+      "{\"buildername\": \"linux_chromium_chromeos_compile_dbg_ng\",
\"buildnumber\": 571, \"slavename\": \"TestSlavename\"}"
     ],
     "name": "get compile targets for scripts",
     "~followup_annotations": [
@@ -201,11 +201,11 @@
       "-u",
       "[SLAVE_BUILD]/src/build/gyp_chromium",
       "--analyzer",
-      "{\"files\": [\"foo.cc\"], \"targets\": [\"chrome\"]}",
+      "{\"files\": [\"foo.cc\"], \"targets\": []}",
       "/path/to/tmp/json"
     ],
     "env": {
-      "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1
gomadir='[BUILD]/goma' target_arch=x64 test_isolation_mode=archive
test_isolation_outdir=https://isolateserver.appspot.com use_goma=1"
+      "GYP_DEFINES": "chromeos=1 component=shared_library dcheck_always_on=1
fastbuild=1 ffmpeg_branding=ChromeOS gomadir='[BUILD]/goma' proprietary_codecs=1
target_arch=x64 test_isolation_mode=archive
test_isolation_outdir=https://isolateserver.appspot.com use_goma=1"
     },
     "name": "analyze",
     "~followup_annotations": [

[dnj, 2014-10-31 23:34:21]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2014-10-31 23:35:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691293002/40001

[commit-bot: I haz the power, 2014-10-31 23:37:27]

Committed patchset #3 (id:40001) as 292781