Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 691273004: Add missing type comments for file_manager_commands.js (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing type comments for file_manager_commands.js BUG=406995 TEST=None Committed: https://crrev.com/9b69a24b7a1cd7a5a45b8debaa0f1133aecd0312 Cr-Commit-Position: refs/heads/master@{#302241}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make them non-nullable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -35 lines) Patch
M ui/file_manager/file_manager/common/js/externs.js View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 47 chunks +197 lines, -34 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
@fukino - To check errors of file_manager.js for refactoring, I added the comments. PTAL the ...
6 years, 1 month ago (2014-10-31 04:11:16 UTC) #2
fukino
https://codereview.chromium.org/691273004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/691273004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode185 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:185: * @param {Event} event Command event. Could you make ...
6 years, 1 month ago (2014-10-31 07:04:22 UTC) #3
hirono
https://codereview.chromium.org/691273004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/691273004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode185 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:185: * @param {Event} event Command event. On 2014/10/31 07:04:21, ...
6 years, 1 month ago (2014-10-31 07:47:29 UTC) #4
fukino
On 2014/10/31 07:47:29, hirono wrote: > https://codereview.chromium.org/691273004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js > File ui/file_manager/file_manager/foreground/js/file_manager_commands.js > (right): > > https://codereview.chromium.org/691273004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode185 ...
6 years, 1 month ago (2014-10-31 07:49:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691273004/20001
6 years, 1 month ago (2014-10-31 07:54:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 08:34:03 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 08:34:34 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9b69a24b7a1cd7a5a45b8debaa0f1133aecd0312
Cr-Commit-Position: refs/heads/master@{#302241}

Powered by Google App Engine
This is Rietveld 408576698