pdf/instance.cc - Issue 691273003: PDF: Fix potential bad indexes in find results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/instance.cc

Issue 691273003: PDF: Fix potential bad indexes in find results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/instance.cc

diff --git a/pdf/instance.cc b/pdf/instance.cc

index 4bd2f787dfec69d80534de5f9686dc5e619f32b9..e187378b90d730966242ee105b397af744d13886 100644

--- a/pdf/instance.cc

+++ b/pdf/instance.cc

@@ -1285,6 +1285,7 @@ void Instance::NotifyNumberOfFindResultsChanged(int total, bool final_result) {

}

void Instance::NotifySelectedFindResultChanged(int current_find_index) {

+ DCHECK_GE(current_find_index, 0);

SelectedFindResultChanged(current_find_index);

}

« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | pdf/pdfium/pdfium_engine.h » ('J')