Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 691253003: Avoid calling P2PSocketHostTcpBase::DoRead in case of error. (Closed)

Created:
6 years, 1 month ago by jiayl
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid calling P2PSocketHostTcpBase::DoRead in case of error. BUG=428204 Committed: https://crrev.com/442d5fa530262184339ff63c745439bd42c0aecf Cr-Commit-Position: refs/heads/master@{#302313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jiayl
PTAL
6 years, 1 month ago (2014-10-30 22:59:08 UTC) #2
Mallinath (Gone from Chromium)
On 2014/10/30 22:59:08, jiayl wrote: > PTAL lgtm
6 years, 1 month ago (2014-10-30 23:31:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691253003/1
6 years, 1 month ago (2014-10-30 23:32:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/1579)
6 years, 1 month ago (2014-10-31 00:41:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691253003/1
6 years, 1 month ago (2014-10-31 19:28:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 20:15:34 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 20:16:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442d5fa530262184339ff63c745439bd42c0aecf
Cr-Commit-Position: refs/heads/master@{#302313}

Powered by Google App Engine
This is Rietveld 408576698