Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 691253002: Move the Developer Website and Licenses links in the App Info dialog (Closed)

Created:
6 years, 1 month ago by sashab
Modified:
6 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the Developer Website and Licenses links in the App Info dialog Move the Developer Website and Licenses links in the App Info dialog to below the description, if they exist. Change the 'View in Webstore' link to always display directly under the app name, even if a developer website is already provided. BUG=423252 Committed: https://crrev.com/ded8aeb9d6a0bd118245496aedfed0e534de6ca9 Cr-Commit-Position: refs/heads/master@{#302538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -128 lines) Patch
M chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc View 7 chunks +7 lines, -94 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h View 5 chunks +21 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc View 6 chunks +97 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sashab
6 years, 1 month ago (2014-10-30 22:53:01 UTC) #2
benwells
lgtm. please post some screenshots on the bug and get aainslie or jleicting's confirmation that ...
6 years, 1 month ago (2014-11-02 22:22:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691253002/1
6 years, 1 month ago (2014-11-04 00:34:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 01:22:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 01:23:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded8aeb9d6a0bd118245496aedfed0e534de6ca9
Cr-Commit-Position: refs/heads/master@{#302538}

Powered by Google App Engine
This is Rietveld 408576698