media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc - Issue 691233002: Added aac bitstream converter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc

Issue 691233002: Added aac bitstream converter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Figured it out Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc

diff --git a/media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc b/media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc

index e5a1a6402d884ff444f548f3cd2b293d50098843..e1900e8a1350a051acdaddfe2bfc4643ae104859 100644

--- a/media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc

+++ b/media/filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc

@@ -328,8 +328,7 @@ TEST_F(FFmpegH264ToAnnexBBitstreamConverterTest, Conversion_FailureNullParams) {

CreatePacket(test_packet.get(), kPacketDataOkWithFieldLen4,

sizeof(kPacketDataOkWithFieldLen4));

- // Try out the actual conversion (should be successful and allocate new

- // packet and destroy the old one). This should fail due to missing extradata.

+ // Try out the actual conversion. This should fail due to missing extradata.

EXPECT_FALSE(converter.ConvertPacket(test_packet.get()));

// Converted will be automatically cleaned up.

« media/filters/ffmpeg_aac_bitstream_converter.h ('K') | « media/filters/ffmpeg_h264_to_annex_b_bitstream_converter.cc ('k') | media/media.gyp » ('j') | no next file with comments »