Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 691223002: Replacing NULL with nullptr (Closed)

Created:
6 years, 1 month ago by Charlie
Modified:
6 years, 1 month ago
Reviewers:
rkc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing NULL with nullptr Committed: https://crrev.com/ed96117639de3157324b96c4876357d8d0236466 Cr-Commit-Position: refs/heads/master@{#302206}

Patch Set 1 #

Patch Set 2 : Using EXPECT_THAT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M components/copresence/handlers/audio/audio_directive_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/handlers/audio/audio_directive_list_unittest.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M components/copresence/mediums/audio/audio_manager_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/copresence/mediums/audio/audio_player_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/copresence/mediums/audio/audio_player_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/copresence/mediums/audio/audio_recorder_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/copresence/mediums/audio/audio_recorder_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie
6 years, 1 month ago (2014-10-30 22:41:03 UTC) #2
rkc
Awesome, thank you for doing this! lgtm
6 years, 1 month ago (2014-10-31 00:22:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691223002/20001
6 years, 1 month ago (2014-10-31 00:28:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 01:10:42 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 01:11:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed96117639de3157324b96c4876357d8d0236466
Cr-Commit-Position: refs/heads/master@{#302206}

Powered by Google App Engine
This is Rietveld 408576698