Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 691163002: Domain Reliability: Histogram upload collector index (Closed)

Created:
6 years, 1 month ago by Deprecated (see juliatuttle)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: Histogram upload collector index BUG= Committed: https://crrev.com/13b6fa46e0ed1b9943685344f10ca320f131ee56 Cr-Commit-Position: refs/heads/master@{#302464}

Patch Set 1 #

Patch Set 2 : Cast upload index to int for histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M components/domain_reliability/context.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
Deprecated (see juliatuttle)
PTAL, davidben.
6 years, 1 month ago (2014-10-30 21:23:25 UTC) #3
davidben
lgtm
6 years, 1 month ago (2014-10-30 22:28:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691163002/1
6 years, 1 month ago (2014-10-31 18:56:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21562)
6 years, 1 month ago (2014-10-31 19:03:41 UTC) #8
Deprecated (see juliatuttle)
asvitkine, PTAL at histograms.xml.
6 years, 1 month ago (2014-10-31 21:27:51 UTC) #11
Alexei Svitkine (slow)
lgtm
6 years, 1 month ago (2014-10-31 23:35:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691163002/1
6 years, 1 month ago (2014-11-01 16:11:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/1986)
6 years, 1 month ago (2014-11-01 17:46:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691163002/1
6 years, 1 month ago (2014-11-03 14:36:53 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/2101)
6 years, 1 month ago (2014-11-03 15:20:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691163002/20001
6 years, 1 month ago (2014-11-03 18:48:16 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-03 19:29:51 UTC) #23
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 19:30:49 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13b6fa46e0ed1b9943685344f10ca320f131ee56
Cr-Commit-Position: refs/heads/master@{#302464}

Powered by Google App Engine
This is Rietveld 408576698