LayoutTests/webaudio/stereopannernode-basic.html - Issue 691143007: Implement StereoPannerNode for robust stereo panning

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webaudio/stereopannernode-basic.html

Issue 691143007: Implement StereoPannerNode for robust stereo panning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3

	4 <head>

	5 <script src="resources/compatibility.js"></script>

	6 <script src="resources/audio-testing.js"></script>

	7 <script src="../resources/js-test.js"></script>

	8 </head>

	9

	10 <body>

	11 <div id="description"></div>

	12 <div id="console"></div>

	13 <script>

	14 description("Test attribute and basic functionality of StereoPannerNode.");

	15

	16 function runTest() {

	17

	18 window.jsTestIsAsync = true;

	19

	20 context = new AudioContext();

	21 var panner = context.createStereoPanner();

	22 window.panner = panner;

	23

	24 shouldBeTrue('panner.numberOfInputs === 1');

	25 shouldBeTrue('panner.numberOfOutputs === 1');

	26 shouldBeTrue('panner.pan.defaultValue === 0.0');

	27 shouldBeTrue('panner.pan.value === 0.0');

	28 panner.pan.value = 1.0;

	29 shouldBeTrue('panner.pan.value === 1.0');

	30

	31 shouldNotThrow('panner.channelCount = 1');

	32 shouldThrow('panner.channelCount = 3');

	33 shouldNotThrow('panner.channelCountMode = "explicit"');

	34 shouldThrow('panner.channelCountMode = "max"');
	Raymond Toy 2014/11/12 18:06:52 Is it possible to set the pan value outside the ra Is it possible to set the pan value outside the range [-1,1]? I assume it's clipped to that range, so there should probably be a test here to show the clipping. hongchan 2014/11/12 22:01:42 For this CL, the clamping only happens internally. Show quoted text On 2014/11/12 18:06:52, Raymond Toy wrote: > Is it possible to set the pan value outside the range [-1,1]? I assume it's > clipped to that range, so there should probably be a test here to show the > clipping. For this CL, the clamping only happens internally. As we discussed, AudioParam should handle the clamping - not the individual node. So the range check will be done later with the improvement on AudioParam. (The internal clamping will be removed along with it as well.)
	35

	36 finishJSTest();

	37 }

	38

	39 runTest();

	40 successfullyParsed = true;

	41 </script>

	42 </body>

	43

	44 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/webaudio/stereopannernode-basic-expected.txt » ('j') | LayoutTests/webaudio/stereopannernode-panning.html » ('J')