LayoutTests/webaudio/stereopannernode-basic.html - Issue 691143007: Implement StereoPannerNode for robust stereo panning

Side by Side Diff: LayoutTests/webaudio/stereopannernode-basic.html

Issue 691143007: Implement StereoPannerNode for robust stereo panning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3

	4 <head>

	5 <script src="resources/compatibility.js"></script>

	6 <script src="resources/audio-testing.js"></script>

	7 <script src="../resources/js-test.js"></script>

	8 </head>

	9

	10 <body>

	11 <div id="description"></div>

	12 <div id="console"></div>

	13 <script>

	14 description("Test attribute and basic functionality of StereoPannerNode.");

	15

	16 function runTest() {

	17 if (window.testRunner) {

	18 testRunner.dumpAsText();

	19 testRunner.waitUntilDone();

	20 }
	Raymond Toy 2014/11/11 19:41:46 I think the if statement is no longer needed. I think the if statement is no longer needed. hongchan 2014/11/12 00:06:53 Done. Show quoted text On 2014/11/11 19:41:46, Raymond Toy wrote: > I think the if statement is no longer needed. Done. Raymond Toy 2014/11/12 00:16:44 I think the style is to say "Done", after you uplo Show quoted text On 2014/11/12 00:06:53, hoch wrote: > On 2014/11/11 19:41:46, Raymond Toy wrote: > > I think the if statement is no longer needed. > > Done. I think the style is to say "Done", after you upload the CL that has the change.
	21

	22 window.jsTestIsAsync = true;

	23

	24 context = new AudioContext();

	25 var panner = context.createStereoPanner();

	26 window.panner = panner;

	27

	28 shouldBeTrue("panner.numberOfInputs === 1");

	29 shouldBeTrue("panner.numberOfOutputs === 1");

	30 shouldBeTrue("panner.pan.defaultValue === 0.0");

	31 shouldBeTrue("panner.pan.value === 0.0");

	32 panner.pan.value = 1.0;

	33 shouldBeTrue("panner.pan.value === 1.0");

	34
	Raymond Toy 2014/11/11 19:41:46 The spec says channelCount cannot be increased abo The spec says channelCount cannot be increased above 2. You should have a test for setting the channelCount to greater than 2. Spec also says channelCountMode cannot be set to "max", so check for that as well. hongchan 2014/11/12 00:06:53 For this CL, I have decided to fix the channelCoun Show quoted text On 2014/11/11 19:41:46, Raymond Toy wrote: > The spec says channelCount cannot be increased above 2. You should have a test > for setting the channelCount to greater than 2. Spec also says channelCountMode > cannot be set to "max", so check for that as well. For this CL, I have decided to fix the channelCount value to 2, and channelCountMode to 'clamped-max.' This needs to be revisited after the discussion on up/down-mixing rules. Raymond Toy 2014/11/12 00:16:44 Will the spec say the channelCount is fixed to 2? Show quoted text On 2014/11/12 00:06:53, hoch wrote: > On 2014/11/11 19:41:46, Raymond Toy wrote: > > The spec says channelCount cannot be increased above 2. You should have a test > > for setting the channelCount to greater than 2. Spec also says > channelCountMode > > cannot be set to "max", so check for that as well. > > For this CL, I have decided to fix the channelCount value to 2, and > channelCountMode to 'clamped-max.' This needs to be revisited after the > discussion on up/down-mixing rules. Will the spec say the channelCount is fixed to 2? I any case, I think you need to test for setting the count > 2 and channelCountMode to "max", which is definitely not allowed.
	35 finishJSTest();

	36 }

	37

	38 runTest();

	39 successfullyParsed = true;

	40 </script>

	41 </body>

	42

	43 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/webaudio/stereopannernode-basic-expected.txt » ('j') | LayoutTests/webaudio/stereopannernode-panning.html » ('J')