Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 691143002: Revert of Windows video capture: Remove duplicated code from GetDeviceSupportedFormats* (Closed)

Created:
6 years, 1 month ago by dmichael (off chromium)
Modified:
6 years, 1 month ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Windows video capture: Remove duplicated code from GetDeviceSupportedFormats* (patchset #3 id:200001 of https://codereview.chromium.org/558503003/) Reason for revert: See https://code.google.com/p/chromium/issues/detail?id=428958 Original issue's description: > Windows video capture: Remove duplicated code from GetDeviceSupportedFormats* > > The code for GetDeviceSupportedFormatsMediaFoundation and GetDeviceSupportedFormatsDirectShow are already implemented in video_capture_device_mf_win.cc and video_capture_device_win.cc respectively. This CL refactors the implementation so that video_capture_device_factory_win.cc can make use of that code. > > Committed: https://crrev.com/b6dae80f8f10b8af1e3026de9f5af4f3128e812a > Cr-Commit-Position: refs/heads/master@{#301891} TBR=mcasas@chromium.org,perkj@chromium.org,tommi@chromium.org,magjed@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ceeb175aea0b422c14c2611bfb12a850a80cd36a Cr-Commit-Position: refs/heads/master@{#302151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -52 lines) Patch
M media/video/capture/win/video_capture_device_factory_win.cc View 4 chunks +104 lines, -21 lines 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 7 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Created Revert of Windows video capture: Remove duplicated code from GetDeviceSupportedFormats*
6 years, 1 month ago (2014-10-30 20:48:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691143002/1
6 years, 1 month ago (2014-10-30 20:50:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 20:52:39 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 20:53:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceeb175aea0b422c14c2611bfb12a850a80cd36a
Cr-Commit-Position: refs/heads/master@{#302151}

Powered by Google App Engine
This is Rietveld 408576698