Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 691133004: Cleanup: Remove SimpleiOSApp xcode project file. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
caryclark
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Remove SimpleiOSApp xcode project file. There is already an GYP version for it in: https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp BUG=None TEST=None R=caryclark@google.com Committed: https://skia.googlesource.com/skia/+/0c9acd5d2ef9ea5563b02a039aff4a8127718880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2935 lines) Patch
D experimental/SimpleiOSApp/SimpleiOSApp.xcodeproj/project.pbxproj View 1 chunk +0 lines, -2935 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tfarina
6 years, 1 month ago (2014-10-30 22:17:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691133004/1
6 years, 1 month ago (2014-10-30 22:17:41 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 22:17:42 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-10-31 04:17:48 UTC) #6
caryclark
I verified that the pbxproj file hasn't been updated since Yang Su checked it in ...
6 years, 1 month ago (2014-11-03 20:40:12 UTC) #7
tfarina
Thanks for the review Cary. Pushing to CQ.
6 years, 1 month ago (2014-11-03 23:08:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691133004/1
6 years, 1 month ago (2014-11-03 23:10:39 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:10:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 0c9acd5d2ef9ea5563b02a039aff4a8127718880

Powered by Google App Engine
This is Rietveld 408576698