Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 691113005: Repurpose unused string for Accessibility (Closed)

Created:
6 years, 1 month ago by gone
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Repurpose unused string for Accessibility The TitleCondensed string property is now used to pass strings for accessibility. This gets around the inability to set the content description normally for the custom menus. BUG=293658 Committed: https://crrev.com/e9ac4cae1e9a6ff4f72c81faa5b109bac2cb7f55 Cr-Commit-Position: refs/heads/master@{#302533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gone
6 years, 1 month ago (2014-11-04 00:04:32 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 1 month ago (2014-11-04 00:06:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691113005/1
6 years, 1 month ago (2014-11-04 00:13:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 01:00:47 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 01:02:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9ac4cae1e9a6ff4f72c81faa5b109bac2cb7f55
Cr-Commit-Position: refs/heads/master@{#302533}

Powered by Google App Engine
This is Rietveld 408576698