Issue 691093003: Exporting classes with internal linkage does not make sense, do not do it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 691093003: Exporting classes with internal linkage does not make sense, do not do it. (Closed)

Created:
6 years, 1 month ago by Nico

Modified:
6 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit), aa1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Exporting classes with internal linkage does not make sense, do not do it. BUG=82385 Committed: https://crrev.com/42fe40fe8249088de89786e55b5d28f6d0f97882 Cr-Commit-Position: refs/heads/master@{#302651}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gin/object_template_builder.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691093003/1

6 years, 1 month ago (2014-11-04 19:27:51 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-04 20:15:08 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/42fe40fe8249088de89786e55b5d28f6d0f97882
Cr-Commit-Position: refs/heads/master@{#302651}