Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 691073002: Add test case for Apple checkout. (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years ago
Reviewers:
Lei Zhang, Ilya Sherman
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add test case for Apple checkout. CVC isn't recognized. TBR=isherman@chromium.org BUG=428926 Committed: https://crrev.com/a705352b9574b339d6a3d34b06618a0570d5a974 Cr-Commit-Position: refs/heads/master@{#302170}

Patch Set 1 #

Patch Set 2 : better test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -0 lines) Patch
A chrome/test/data/autofill/heuristics/input/23_checkout_m_amazon.com.html View 1 chunk +629 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/input/23_checkout_m_apple.com.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/23_checkout_m_apple.com.out View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
6 years, 1 month ago (2014-10-30 19:19:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691073002/20001
6 years, 1 month ago (2014-10-30 20:50:06 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 22:18:53 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a705352b9574b339d6a3d34b06618a0570d5a974 Cr-Commit-Position: refs/heads/master@{#302170}
6 years, 1 month ago (2014-10-30 22:19:33 UTC) #6
Lei Zhang
Did you mean to add 23_checkout_m_amazon.com.html in this CL? There's no corresponding output file.
6 years ago (2014-12-19 23:07:17 UTC) #8
Evan Stade
6 years ago (2014-12-19 23:39:38 UTC) #9
Message was sent while issue was closed.
hmmm. I either meant to add an output for not add the input. Don't know which.

Powered by Google App Engine
This is Rietveld 408576698