Reopen a Guest browser and not the User Manager if another Guest browser is already open.

Reopen a Guest browser and not the User Manager if another Guest browser is already open.

We currently have code that ensures that if the last used profile is Guest, we should
open the User Manager. This doesn't work if, for example, you download a file
in the Guest browser, and then click on it top open it. In this case, it's fine
to open a new Guest browser window, as one already exists (and opening the User
Manager is a very weird experience)

BUG=423118
TEST=Start Chrome with --enable-new-avatar-menu. From the avatar menu, choose "Switch person"
and launch a new Guest browser. In the Guest browser, download a file, and then click on
it from the dwonload shelf at the bottom of the browser. The file should open in a
new tab of the Guest window.

Committed: https://crrev.com/421a46965a0acd3180d0706a6dad445b5b11e164
Cr-Commit-Position: refs/heads/master@{#302431}

[noms (inactive), 2014-10-30 18:56:42]

noms@chromium.org changed reviewers:
+ sky@chromium.org

[noms (inactive), 2014-10-30 18:56:42]

Hi Scott,

This should fix another guest browser edge case (being less strict about
force-opening the User Manager). Please take a look. Thanks!

[sky, 2014-10-30 21:17:51]

https://codereview.chromium.org/691063002/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/691063002/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:642:
last_used_profile->GetOffTheRecordProfile()) : -1;
I suspect the -1 to a size_t is going to cause warnings. You don't really the
size though right, just if it's empty. Can you convert to a boolean here?

[noms (inactive), 2014-10-31 19:52:10]

https://codereview.chromium.org/691063002/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/691063002/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:642:
last_used_profile->GetOffTheRecordProfile()) : -1;
On 2014/10/30 21:17:51, sky wrote:
> I suspect the -1 to a size_t is going to cause warnings. You don't really the
> size though right, just if it's empty. Can you convert to a boolean here?

Done. Also fixed the logic a bit (there needs to be the extra check for the
guest profile or else it gets triggered for regular profiles with no incognito
browsers...)

[sky, 2014-10-31 22:39:45]

LGTM

https://codereview.chromium.org/691063002/diff/40001/chrome/browser/ui/startu...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/691063002/diff/40001/chrome/browser/ui/startu...
chrome/browser/ui/startup/startup_browser_creator.cc:640: bool
has_guest_browsers = last_used_profile->IsGuestSession() ?
nit: = last_used_profile->IsGuestSession() &&
chrome::GetTotalBrowserCountForProfile(
 642               last_used_profile->GetOffTheRecordProfile()) > 0

[noms (inactive), 2014-11-03 15:05:03]

Thanks so much!

https://codereview.chromium.org/691063002/diff/40001/chrome/browser/ui/startu...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/691063002/diff/40001/chrome/browser/ui/startu...
chrome/browser/ui/startup/startup_browser_creator.cc:640: bool
has_guest_browsers = last_used_profile->IsGuestSession() ?
On 2014/10/31 22:39:45, sky wrote:
> nit: = last_used_profile->IsGuestSession() &&
> chrome::GetTotalBrowserCountForProfile(
>  642               last_used_profile->GetOffTheRecordProfile()) > 0

Done.

[noms (inactive), 2014-11-03 15:05:11]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-11-03 15:05:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691063002/60001

[commit-bot: I haz the power, 2014-11-03 15:49:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-03 15:50:27]

Patchset 4 (id:??) landed as
https://crrev.com/421a46965a0acd3180d0706a6dad445b5b11e164
Cr-Commit-Position: refs/heads/master@{#302431}