Domain Reliability: Mark beacons from previous networks.

components/domain_reliability/monitor.cc

Index: components/domain_reliability/monitor.cc
diff --git a/components/domain_reliability/monitor.cc b/components/domain_reliability/monitor.cc
index d267a923ace009c6d11106984d78850829488dbb..d0bb546f12f1a009519cc6b5b01f8ad3de87953a 100644
--- a/components/domain_reliability/monitor.cc
+++ b/components/domain_reliability/monitor.cc
@@ -33,6 +33,7 @@ DomainReliabilityMonitor::DomainReliabilityMonitor(
       discard_uploads_set_(false),
       weak_factory_(this) {
   DCHECK(OnPrefThread());
+  net::NetworkChangeNotifier::AddNetworkChangeObserver(this);
 }
 
 DomainReliabilityMonitor::DomainReliabilityMonitor(
@@ -51,6 +52,7 @@ DomainReliabilityMonitor::DomainReliabilityMonitor(
       discard_uploads_set_(false),
       weak_factory_(this) {
   DCHECK(OnPrefThread());
+  net::NetworkChangeNotifier::AddNetworkChangeObserver(this);
 }
 
 DomainReliabilityMonitor::~DomainReliabilityMonitor() {
@@ -60,6 +62,7 @@ DomainReliabilityMonitor::~DomainReliabilityMonitor() {
     DCHECK(OnPrefThread());
 
   ClearContexts();
+  net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
 }
 
 void DomainReliabilityMonitor::MoveToNetworkThread() {
@@ -144,6 +147,11 @@ void DomainReliabilityMonitor::OnCompleted(net::URLRequest* request,
   }
 }
 
+void DomainReliabilityMonitor::OnNetworkChanged(
+    net::NetworkChangeNotifier::ConnectionType type) {
+  last_network_change_time_ = time_->NowTicks();

[davidben, 2014/11/03 19:25:34]

Perhaps a test in monitor_unittest.cc to provide coverage over this codepath?
You could call NotifyObserversOfNetworkChangeForTests to simulate a few of
these.

[Deprecated (see juliatuttle), 2014/11/04 17:56:52]

Hmm. I don't have an easy way to test the effects of that, short of duplicating
the context unittests at the monitor layer. (I could add
GetLastNetworkChangeTimeForTesting, but that's getting weird.)

[davidben, 2014/11/04 19:12:35]

Mm. I dunno, it seems worth having an integration test or two to ensure that
this assembly is hooked up together right. (Contexts all alias the right
last_network_change_time_ which gets updated, etc.)

+}
+
 void DomainReliabilityMonitor::ClearBrowsingData(
    DomainReliabilityClearMode mode) {
   DCHECK(OnNetworkThread());
@@ -218,6 +226,7 @@ DomainReliabilityContext* DomainReliabilityMonitor::AddContext(
       new DomainReliabilityContext(time_.get(),
                                    scheduler_params_,
                                    upload_reporter_string_,
+                                   &last_network_change_time_,
                                    &dispatcher_,
                                    uploader_.get(),
                                    config.Pass());