Domain Reliability: Mark beacons from previous networks.

components/domain_reliability/context_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.

[davidben, 2014/10/30 21:18:00]

This probably wants tests (not sure if here or elsewhere) to test that
NetworkChangeObserver behaves as expected. I'm not sure it does right now. There
seems to be a test API to simulate network changes.

[Deprecated (see juliatuttle), 2014/10/31 22:01:02]

The Context itself just bases it on the (shared) last_network_change_time, so I
added a test against that here.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/context.h"
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 28 matching lines @@
  protected:
   DomainReliabilityContextTest()
       : dispatcher_(&time_),
         params_(MakeTestSchedulerParams()),
         uploader_(base::Bind(&DomainReliabilityContextTest::OnUploadRequest,
                              base::Unretained(this))),
         upload_reporter_string_("test-reporter"),
         context_(&time_,
                  params_,
                  upload_reporter_string_,
+                 last_network_change_time_,
                  &dispatcher_,
                  &uploader_,
                  MakeTestConfig().Pass()),
         upload_pending_(false) {}
 
   TimeDelta min_delay() const { return params_.minimum_upload_delay; }
   TimeDelta max_delay() const { return params_.maximum_upload_delay; }
   TimeDelta retry_interval() const { return params_.upload_retry_interval; }
   TimeDelta zero_delta() const { return TimeDelta::FromMicroseconds(0); }
 
@@ skipping 23 matching lines @@
 
   bool CheckCounts(size_t index,
                    unsigned expected_successful,
                    unsigned expected_failed) {
     unsigned successful, failed;
     context_.GetRequestCountsForTesting(index, &successful, &failed);
     return successful == expected_successful && failed == expected_failed;
   }
 
   MockTime time_;
+  base::TimeTicks last_network_change_time_;
   DomainReliabilityDispatcher dispatcher_;
   DomainReliabilityScheduler::Params params_;
   MockUploader uploader_;
   std::string upload_reporter_string_;
   DomainReliabilityContext context_;
 
  private:
   void OnUploadRequest(
       const std::string& report_json,
       const GURL& upload_url,
@@ skipping 78 matching lines @@
   EXPECT_EQ(GURL("https://exampleuploader/upload"), upload_url());
   CallUploadCallback(true);
 
   EXPECT_TRUE(CheckNoBeacons());
   EXPECT_TRUE(CheckCounts(0, 0, 0));
   EXPECT_TRUE(CheckCounts(1, 0, 0));
 }
 
 }  // namespace
 }  // namespace domain_reliability