Issue 691033002: Revert of scale xmin and xmax for FontMetrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 691033002: Revert of scale xmin and xmax for FontMetrics (Closed)

Created:
6 years, 1 month ago by robertphillips

Modified:
6 years, 1 month ago

Reviewers:
bungeman-skia, mtklein, reed2, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of scale xmin and xmax for FontMetrics (patchset #1 id:1 of https://codereview.chromium.org/685153004/) Reason for revert: Experimental revert to see if this is blocking the DEPS roll Original issue's description: > scale xmin and xmax for FontMetrics > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/79c276e4fd93d9c9fd57a45bc6929c48e4415b2f TBR=mtklein@google.com,bungeman@google.com,reed@google.com,reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/650076027f958a67584c1a906181d4f5c75a6d2a

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of scale xmin and xmax for FontMetrics

6 years, 1 month ago (2014-10-30 16:59:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691033002/1

6 years, 1 month ago (2014-10-30 16:59:32 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-30 16:59:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 650076027f958a67584c1a906181d4f5c75a6d2a