Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 691023003: Fix an Aura crash several minutes into V2Mirroring (Closed)

Created:
6 years, 1 month ago by GusFernandez
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix an Aura crash several minutes into V2Mirroring Since we deleted the gfx::screen each time we closed an app, A query to the screen size during metrics gathering was causing a check failure. BUG= Committed: https://crrev.com/7c0546789b9d1eaf04d57b816847cf18aa5d684e Cr-Commit-Position: refs/heads/master@{#302194}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove an unnecessary #include #

Patch Set 3 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_window.cc View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
GusFernandez
Upstreamed changes.
6 years, 1 month ago (2014-10-30 22:08:47 UTC) #2
gunsch
https://codereview.chromium.org/691023003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/691023003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode25 chromecast/browser/cast_browser_main_parts.cc:25: #include "ui/ozone/public/ozone_switches.h" kIgnoreGpuBlacklist is in content_switches, which is already ...
6 years, 1 month ago (2014-10-30 22:25:02 UTC) #3
GusFernandez
https://codereview.chromium.org/691023003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/691023003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode25 chromecast/browser/cast_browser_main_parts.cc:25: #include "ui/ozone/public/ozone_switches.h" On 2014/10/30 22:25:02, gunsch wrote: > kIgnoreGpuBlacklist ...
6 years, 1 month ago (2014-10-30 22:59:54 UTC) #4
gunsch
lgtm
6 years, 1 month ago (2014-10-30 23:00:28 UTC) #5
lcwu1
lgtm
6 years, 1 month ago (2014-10-30 23:04:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691023003/40001
6 years, 1 month ago (2014-10-30 23:21:19 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-31 00:03:00 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 00:03:30 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7c0546789b9d1eaf04d57b816847cf18aa5d684e
Cr-Commit-Position: refs/heads/master@{#302194}

Powered by Google App Engine
This is Rietveld 408576698