Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 690943004: Fixed bit-testing to use '&' instead of '|', found by /analyze (Closed)

Created:
6 years, 1 month ago by brucedawson
Modified:
6 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed bit-testing to use '&' instead of '|', found by /analyze /analyze pointed out that the bit testing in gles2_cmd_decoder.cc was always returning true due to the wrong operator being used. Warnings were: src\gpu\command_buffer\service\gles2_cmd_decoder.cc (3128) : warning C6316: Incorrect operator: tested expression is constant and non-zero. Use bitwise-and to determine whether bits are set. (5103) : warning C6316: Incorrect operator: tested expression is constant and non-zero. Use bitwise-and to determine whether bits are set. BUG=427616 Committed: https://crrev.com/182491565a86a2de1d1bd14582f54eeecf5a1191 Cr-Commit-Position: refs/heads/master@{#302343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
I've been running VC++'s /analyze on Chrome to see what bugs it finds and it ...
6 years, 1 month ago (2014-10-30 22:51:48 UTC) #2
Zhenyao Mo
On 2014/10/30 22:51:48, brucedawson wrote: > I've been running VC++'s /analyze on Chrome to see ...
6 years, 1 month ago (2014-10-31 17:29:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690943004/1
6 years, 1 month ago (2014-10-31 20:54:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 23:02:42 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 23:03:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/182491565a86a2de1d1bd14582f54eeecf5a1191
Cr-Commit-Position: refs/heads/master@{#302343}

Powered by Google App Engine
This is Rietveld 408576698