[builders.py] Fix _deps_builders definition

[builders.py] Add comment to _deps_builders about duplicated mappings

Mac10.6 (deps) is used for all mac ports.

R=dpranke
BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184897

[tyoshino (SeeGerritForStatus), 2014-10-30 12:25:15]

tyoshino@chromium.org changed reviewers:
+ dpranke@chromium.org

[tyoshino (SeeGerritForStatus), 2014-10-30 12:25:53]

I don't if this is intentional but as I noticed this and looks weird, I'd like
you to take a look at this.

[tyoshino (SeeGerritForStatus), 2014-10-30 12:26:39]

Oh, can we just remove this? No one is referring to this dictionary.

[tyoshino (SeeGerritForStatus), 2014-10-30 12:27:19]

On 2014/10/30 12:26:39, tyoshino wrote:
> Oh, can we just remove this? No one is referring to this dictionary.

nvm. It's used by deps_builder_name_for_port_name

[Dirk Pranke, 2014-10-30 19:08:40]

https://codereview.chromium.org/690943002/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/port/builders.py (right):

https://codereview.chromium.org/690943002/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/port/builders.py:71: "mac-retina": "WebKit
Mac10.8 (deps)",
Unfortunately, these bots don't actually exist, which is why we have the hack of
mapping the ports onto the only bot that does.

Arguably we should just not attempt to look at the deps bots at all in
update-flaky-tests, but it's probably not worth changing at this point
(hopefully the Blink/Chromium merge will happen soon enough).

[tyoshino (SeeGerritForStatus), 2014-11-05 05:42:31]

https://codereview.chromium.org/690943002/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/port/builders.py (right):

https://codereview.chromium.org/690943002/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/port/builders.py:71: "mac-retina": "WebKit
Mac10.8 (deps)",
On 2014/10/30 19:08:40, Dirk Pranke wrote:
> Unfortunately, these bots don't actually exist, which is why we have the hack
of
> mapping the ports onto the only bot that does.
> 
> Arguably we should just not attempt to look at the deps bots at all in
> update-flaky-tests, but it's probably not worth changing at this point
> (hopefully the Blink/Chromium merge will happen soon enough).

I see. OK. I updated the CL to just add a comment.

[Dirk Pranke, 2014-11-05 15:37:20]

lgtm

[tyoshino (SeeGerritForStatus), 2014-11-06 03:09:15]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-11-06 03:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690943002/20001

[commit-bot: I haz the power, 2014-11-06 05:38:13]

Committed patchset #2 (id:20001) as 184897