ppapi/proxy/udp_socket_private_resource.cc - Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/udp_socket_private_resource.cc

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/udp_socket_private_resource.cc

diff --git a/ppapi/proxy/udp_socket_private_resource.cc b/ppapi/proxy/udp_socket_private_resource.cc

index af43c10fb05e281043f35d3b0476553d9072853e..60afc6f3593f1b8b780329803f595ccbef82e689 100644

--- a/ppapi/proxy/udp_socket_private_resource.cc

+++ b/ppapi/proxy/udp_socket_private_resource.cc

@@ -41,7 +41,9 @@ int32_t UDPSocketPrivateResource::SetSocketFeature(

NOTREACHED();

return PP_ERROR_BADARGUMENT;

}

- int32_t result = SetOptionImpl(public_name, value, NULL);

+ int32_t result = SetOptionImpl(public_name, value,

+ true, // Check bind() state.

+ NULL);

return result == PP_OK_COMPLETIONPENDING ? PP_OK : result;

}

« no previous file with comments | « ppapi/proxy/tcp_socket_resource_base.cc ('k') | ppapi/proxy/udp_socket_resource.h » ('j') | no next file with comments »