Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: ppapi/proxy/udp_socket_resource_base.h

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/udp_socket_resource.cc ('k') | ppapi/proxy/udp_socket_resource_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/udp_socket_resource_base.h
diff --git a/ppapi/proxy/udp_socket_resource_base.h b/ppapi/proxy/udp_socket_resource_base.h
index 5400f6be99554d3dec8f57d430d1912954fd8c54..bddc5e338bd3a63c6ca8e874052336c891673270 100644
--- a/ppapi/proxy/udp_socket_resource_base.h
+++ b/ppapi/proxy/udp_socket_resource_base.h
@@ -54,6 +54,7 @@ class PPAPI_PROXY_EXPORT UDPSocketResourceBase: public PluginResource {
int32_t SetOptionImpl(PP_UDPSocket_Option name,
const PP_Var& value,
+ bool check_bind_state,
scoped_refptr<TrackedCallback> callback);
int32_t BindImpl(const PP_NetAddress_Private* addr,
scoped_refptr<TrackedCallback> callback);
@@ -106,6 +107,11 @@ class PPAPI_PROXY_EXPORT UDPSocketResourceBase: public PluginResource {
PP_Resource* output_addr);
bool private_api_;
+
+ // |bind_called_| holds whether the Bind() is called, while |bound_| holds
+ // whether Bind() is successfully done. Bind() is asynchronous method, so
+ // the timing on which these are set are slightly different.
bbudge 2014/11/07 21:39:14 Could we reword this? 111 // |bind_called_| is
hidehiko 2014/11/07 22:12:21 Done.
+ bool bind_called_;
bool bound_;
bool closed_;
« no previous file with comments | « ppapi/proxy/udp_socket_resource.cc ('k') | ppapi/proxy/udp_socket_resource_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698