Remove timing limitation of SetOption invocation for PPAPI sockets.

net/udp/udp_socket_libevent.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_UDP_UDP_SOCKET_LIBEVENT_H_
 #define NET_UDP_UDP_SOCKET_LIBEVENT_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 76 matching lines @@
   // |callback| is the user callback function to call on complete.
   // Returns a net error code, or ERR_IO_PENDING if the IO is in progress.
   // If ERR_IO_PENDING is returned, the caller must keep |buf| and |address|
   // alive until the callback is called.
   int SendTo(IOBuffer* buf,
              int buf_len,
              const IPEndPoint& address,
              const CompletionCallback& callback);
 
   // Set the receive buffer size (in bytes) for the socket.
+  // Returns a net error code.
   int SetReceiveBufferSize(int32 size);
 
   // Set the send buffer size (in bytes) for the socket.
+  // Returns a net error code.
   int SetSendBufferSize(int32 size);
 
   // Returns true if the socket is already connected or bound.
   bool is_connected() const { return socket_ != kInvalidSocket; }
 
   const BoundNetLog& NetLog() const { return net_log_; }
 
-  // Sets corresponding flags in |socket_options_| to allow the socket
-  // to share the local address to which the socket will be bound with
-  // other processes. Should be called before Bind().
-  void AllowAddressReuse();
+  // Allows the socket to share the local address to which the socket will be
+  // bound with other processes.
+  // Returns a net error code.
+  int AllowAddressReuse();
 
-  // Sets corresponding flags in |socket_options_| to allow sending
-  // and receiving packets to and from broadcast addresses. Should be
-  // called before Bind().
-  void AllowBroadcast();
+  // Disallows the socket to share the local address to which the socket will
+  // be bound with other processes.
+  // Returns a net error code.
+  int DisallowAddressReuse();
+
+  // Allows sending and receiving packets to and from broadcast addresses.
+  // Returns a net error code.
+  int AllowBroadcast();
+
+  // Disallows sending and receiving packets to and from broadcast addresses.
+  // Returns a net error code.
+  int DisallowBroadcast();
 
   // Join the multicast group.
   // |group_address| is the group address to join, could be either
   // an IPv4 or IPv6 address.
   // Return a network error code.
   int JoinGroup(const IPAddressNumber& group_address) const;
 
   // Leave the multicast group.
   // |group_address| is the group address to leave, could be either
   // an IPv4 or IPv6 address. If the socket hasn't joined the group,
@@ skipping 37 matching lines @@
   // Return a network error code.
   int SetDiffServCodePoint(DiffServCodePoint dscp);
 
   // Resets the thread to be used for thread-safety checks.
   void DetachFromThread();
 
  private:
   enum SocketOptions {
     SOCKET_OPTION_REUSE_ADDRESS  = 1 << 0,
     SOCKET_OPTION_BROADCAST      = 1 << 1,
-    SOCKET_OPTION_MULTICAST_LOOP = 1 << 2
+    SOCKET_OPTION_MULTICAST_LOOP = 1 << 2,
+    SOCKET_OPTION_RCVBUF_SIZE    = 1 << 3,
+    SOCKET_OPTION_SNDBUF_SIZE    = 1 << 4
   };
 
   class ReadWatcher : public base::MessageLoopForIO::Watcher {
    public:
     explicit ReadWatcher(UDPSocketLibevent* socket) : socket_(socket) {}
 
     // MessageLoopForIO::Watcher methods
 
     void OnFileCanReadWithoutBlocking(int /* fd */) override;
 
@@ skipping 45 matching lines @@
                     const IPEndPoint* address,
                     const CompletionCallback& callback);
 
   int InternalConnect(const IPEndPoint& address);
   int InternalRecvFrom(IOBuffer* buf, int buf_len, IPEndPoint* address);
   int InternalSendTo(IOBuffer* buf, int buf_len, const IPEndPoint* address);
 
   // Applies |socket_options_| to |socket_|. Should be called before
   // Bind().
   int SetSocketOptions();
+  int SetAddressReuseInternal(bool value);

[jar (doing other things), 2014/11/04 22:51:09]

nit: use better variable name than |value|.

Perhaps |reuse_address|, and in the next line |broadcast|.

[hidehiko, 2014/11/05 12:48:30]

Done.

+  int SetBroadcastInternal(bool value);
+  int SetReceiveBufferSizeInternal(int32 size);
+  int SetSendBufferSizeInternal(int32 size);
+
   int DoBind(const IPEndPoint& address);
   // Binds to a random port on |address|.
   int RandomBind(const IPAddressNumber& address);
 
   int socket_;
   int addr_family_;
 
   // Bitwise-or'd combination of SocketOptions. Specifies the set of
   // options that should be applied to |socket_| before Bind().
   int socket_options_;
 
+  // Buffer size set before Bind(). This should be applied
+  // in SetSocketOptions().
+  int32 rcvbuf_size_;
+  int32 sndbuf_size_;
+
   // Multicast interface.
   uint32 multicast_interface_;
 
   // Multicast socket options cached for SetSocketOption.
   // Cannot be used after Bind().
   int multicast_time_to_live_;
 
   // How to do source port binding, used only when UDPSocket is part of
   // UDPClientSocket, since UDPServerSocket provides Bind.
   DatagramSocket::BindType bind_type_;
@@ skipping 31 matching lines @@
   CompletionCallback write_callback_;
 
   BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(UDPSocketLibevent);
 };
 
 }  // namespace net
 
 #endif  // NET_UDP_UDP_SOCKET_LIBEVENT_H_