Remove timing limitation of SetOption invocation for PPAPI sockets.

ppapi/api/ppb_udp_socket.idl

 /* Copyright 2013 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the <code>PPB_UDPSocket</code> interface.
  */
 
-[generate_thunk]
-
 label Chrome {
-  M29 = 1.0
+  M29 = 1.0,
+  M41 = 1.1
 };
 
 /**
  * Option names used by <code>SetOption()</code>.
  */
 [assert_size(4)]
 enum PP_UDPSocket_Option {
   /**
    * Allows the socket to share the local address to which it will be bound with
    * other processes. Value's type should be <code>PP_VARTYPE_BOOL</code>.
    * This option can only be set before calling <code>Bind()</code>.

[bbudge, 2014/12/09 18:37:38]

Looking at the UDP resource base implementation, ADDRESS_REUSE and BROADCAST are
checked in the same way, but the documentation here says they're different.
Which is correct?

[hidehiko, 2014/12/09 19:51:42]

The comment is correct. Please see my reply in the source file, too.

    */
   PP_UDPSOCKET_OPTION_ADDRESS_REUSE = 0,
 
   /**
    * Allows sending and receiving packets to and from broadcast addresses.
    * Value's type should be <code>PP_VARTYPE_BOOL</code>.
-   * This option can only be set before calling <code>Bind()</code>.
+   * On version 1.0, this option can only be set before calling
+   * <code>Bind()</code>. On version 1.1 or later, there is no such limitation.
    */
   PP_UDPSOCKET_OPTION_BROADCAST = 1,
 
   /**
    * Specifies the total per-socket buffer space reserved for sends. Value's
    * type should be <code>PP_VARTYPE_INT32</code>.
-   * This option can only be set after a successful <code>Bind()</code> call.
+   * On version 1.0, this option can only be set before calling

[bbudge, 2014/12/09 18:37:38]

Option can be set only *after* Bind().
And below.

[hidehiko, 2014/12/09 19:51:42]

Oops, good catch. I wrongly updated the comment. Reverted to the original
sentences.

+   * <code>Bind()</code>. On version 1.1 or later, there is no such limitation.
    *
    * Note: This is only treated as a hint for the browser to set the buffer
    * size. Even if <code>SetOption()</code> succeeds, the browser doesn't
    * guarantee it will conform to the size.
    */
   PP_UDPSOCKET_OPTION_SEND_BUFFER_SIZE = 2,
 
   /**
    * Specifies the total per-socket buffer space reserved for receives. Value's
    * type should be <code>PP_VARTYPE_INT32</code>.
-   * This option can only be set after a successful <code>Bind()</code> call.
+   * On version 1.0, this option can only be set before calling
+   * <code>Bind()</code>. On version 1.1 or later, there is no such limitation.
    *
    * Note: This is only treated as a hint for the browser to set the buffer
    * size. Even if <code>SetOption()</code> succeeds, the browser doesn't
    * guarantee it will conform to the size.
    */
   PP_UDPSOCKET_OPTION_RECV_BUFFER_SIZE = 3
 };
 
 /**
  * The <code>PPB_UDPSocket</code> interface provides UDP socket operations.
@@ skipping 126 matching lines @@
    * @param[in] value The option value to set.
    * @param[in] callback A <code>PP_CompletionCallback</code> to be called upon
    * completion.
    *
    * @return An int32_t containing an error code from <code>pp_errors.h</code>.
    */
   int32_t SetOption([in] PP_Resource udp_socket,
                     [in] PP_UDPSocket_Option name,
                     [in] PP_Var value,
                     [in] PP_CompletionCallback callback);
+
+  /**
+   * Sets a socket option on the UDP socket.
+   * Please see the <code>PP_UDPSocket_Option</code> description for option
+   * names, value types and allowed values.
+   *
+   * @param[in] udp_socket A <code>PP_Resource</code> corresponding to a UDP
+   * socket.
+   * @param[in] name The option to set.
+   * @param[in] value The option value to set.
+   * @param[in] callback A <code>PP_CompletionCallback</code> to be called upon
+   * completion.
+   *
+   * @return An int32_t containing an error code from <code>pp_errors.h</code>.
+   */
+  [version=1.1]
+  int32_t SetOption([in] PP_Resource udp_socket,
+                    [in] PP_UDPSocket_Option name,
+                    [in] PP_Var value,
+                    [in] PP_CompletionCallback callback);
 };