Deterministic build: Compare step: Fix the logging when the files have a different size.

Deterministic build: Compare step: Fix the logging when the files have a different size.

BUG=314403
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292776

[Sébastien Marchand, 2014-10-31 20:14:06]

sebmarchand@chromium.org changed reviewers:
+ maruel@chromium.org

[Sébastien Marchand, 2014-10-31 20:14:24]

Oops ! PTAL.

[M-A Ruel, 2014-10-31 20:16:59]

lgtm

https://codereview.chromium.org/690893004/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py
(right):

https://codereview.chromium.org/690893004/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:89:
difference = ('different size' if files_diffs == -1 else
I'd go all the way while at it;
if files_diffs == -1:
  difference = 'different size: %d != %d' % (file_len,
os.stat(second_file).st_size)
else:
  difference = '%d out of %d bytes are different (%.2f%%)' % (
      files_diffs, file_len, 100.0 * files_diffs / file_len))

[Sébastien Marchand, 2014-10-31 20:23:28]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-10-31 20:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690893004/20001

[commit-bot: I haz the power, 2014-10-31 20:25:18]

Committed patchset #2 (id:20001) as 292776