Issue 690803002: Add a basic XMLHttpRequest implementation

Issue 690803002: Add a basic XMLHttpRequest implementation (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a basic XMLHttpRequest implementation R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e49aa4ed52bee4641fdeb934bebae6bc791e6c04

Patch Set 3 : Less console.log #

Patch Set 4 : Propagate error #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -0 lines)			Patch
A	sky/framework/shell.sky	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	sky/framework/xmlhttprequest.sky	View	1 2 3	1 chunk	+45 lines, -0 lines	0 comments	Download
A	sky/tests/services/xhr.sky	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download
A	sky/tests/services/xhr-expected.txt	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm, please fix before landing. https://codereview.chromium.org/690803002/diff/20001/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky (right): https://codereview.chromium.org/690803002/diff/20001/sky/framework/xmlhttprequest.sky#newcode16 sky/framework/xmlhttprequest.sky:16: XMLHttpRequest.prototype.onerror = function() { ...

6 years, 1 month ago (2014-10-29 19:39:47 UTC) #2

abarth-chromium

fixed https://codereview.chromium.org/690803002/diff/20001/sky/tests/services/xhr.sky File sky/tests/services/xhr.sky (right): https://codereview.chromium.org/690803002/diff/20001/sky/tests/services/xhr.sky#newcode2 sky/tests/services/xhr.sky:2: xxx On 2014/10/29 at 19:39:46, esprehn wrote: > ...

6 years, 1 month ago (2014-10-29 19:47:56 UTC) #3

abarth-chromium

6 years, 1 month ago (2014-10-29 19:48:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
e49aa4ed52bee4641fdeb934bebae6bc791e6c04 (presubmit successful).

Expand Messages | Collapse Messages