pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart - Issue 690793004: make deprecated elements have low suggestion relevance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 690793004: make deprecated elements have low suggestion relevance (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

index 2ad1b8b911557341eb6f812195e02ba119cc3c79..d98c968e72854655c189b1cfd00575cc59353388 100644

--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

@@ -283,13 +283,14 @@ class _AbstractSuggestionBuilder extends GeneralizingElementVisitor {

!_completions.add(completion)) {

return;

}

+ bool isDeprecated = element.isDeprecated;

CompletionSuggestion suggestion = new CompletionSuggestion(

kind,

- CompletionRelevance.DEFAULT,

+ isDeprecated ? CompletionRelevance.LOW : CompletionRelevance.DEFAULT,

completion,

completion.length,

- element.isDeprecated,

+ isDeprecated,

false);

suggestion.element = protocol.newElement_fromEngine(element);

if (suggestion.element != null) {