pkg/analysis_server/lib/src/services/completion/imported_computer.dart - Issue 690793004: make deprecated elements have low suggestion relevance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 690793004: make deprecated elements have low suggestion relevance (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

index 12941090bfc8a668282ef24b90bbf9c35369d74f..2c9034dce399e761487c5b90d1ad1d76b0bd718c 100644

--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

@@ -224,7 +224,7 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {

String completion = element.displayName;

CompletionSuggestion suggestion = new CompletionSuggestion(

CompletionSuggestionKind.INVOCATION,

- relevance,

+ element.isDeprecated ? CompletionRelevance.LOW : relevance,

completion,

completion.length,

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/local_computer.dart » ('j') | no next file with comments »