Threaded data provider: Support main thread data notifications (Blink side)

Source/core/html/parser/HTMLDocumentParser.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 57 matching lines @@
         || (contextTag.matches(noscriptTag) && options.scriptEnabled)
         || contextTag.matches(noframesTag))
         return reportErrors ? HTMLTokenizer::RAWTEXTState : HTMLTokenizer::PLAINTEXTState;
     if (contextTag.matches(scriptTag))
         return reportErrors ? HTMLTokenizer::ScriptDataState : HTMLTokenizer::PLAINTEXTState;
     if (contextTag.matches(plaintextTag))
         return HTMLTokenizer::PLAINTEXTState;
     return HTMLTokenizer::DataState;
 }
 
-class ParserDataReceiver : public blink::WebThreadedDataReceiver {
+class ParserDataReceiver : public WebThreadedDataReceiver {
 public:
-    explicit ParserDataReceiver(WeakPtr<BackgroundHTMLParser> backgroundParser)
+    explicit ParserDataReceiver(WeakPtr<BackgroundHTMLParser> backgroundParser, WeakPtrWillBeRawPtr<Document> document)
         : m_backgroundParser(backgroundParser)
+        , m_document(document)
     {
     }
 
     // WebThreadedDataReceiver
     virtual void acceptData(const char* data, int dataLength) override final
     {
         ASSERT(backgroundThread() && backgroundThread()->isCurrentThread());
         if (m_backgroundParser.get())
             m_backgroundParser.get()->appendRawBytesFromParserThread(data, dataLength);
     }
 
     virtual blink::WebThread* backgroundThread() override final
     {
         if (HTMLParserThread::shared())
             return &HTMLParserThread::shared()->platformThread();
 
         return nullptr;
     }
 
+    virtual bool needsMainthreadDataCopy() override final { return InspectorInstrumentation::hasFrontends(); }
+    virtual void acceptMainthreadDataNotification(const char* data, int dataLength, int encodedDataLength) override final
+    {

[kouhei (in TOK), 2014/11/18 04:49:55]

please add ASSERT(isMainThread());

+        ASSERT(!data || m_needMainthreadDataCopy);
+        if (m_document.get())
+            m_document.get()->loader()->acceptDataFromThreadedReceiver(data, dataLength, encodedDataLength);
+    }
+
 private:
     WeakPtr<BackgroundHTMLParser> m_backgroundParser;
+    WeakPtrWillBeRawPtr<Document> m_document;

[kouhei (in TOK), 2014/11/18 04:49:55]

This would not work on Oilpan, as RawPtr is not nuked when Document is
destructed.
I'm not sure how to solve this though...

haraken: Do you have any ideas?

[haraken, 2014/11/18 04:57:27]

Can't this simply be a RefPtr?

In the first place, I don't understand why Document::contextDocument() returns a
WeakPtrWillBeRawPtr. It's error-prone to pass WeakPtr around, so I think
Document::contextDocument() should just return a Document*. It looks like almost
all call sites of Document::contextDocument() are interested in a Document*
pointer, not WeakPtr<Document>.

 };
 
 HTMLDocumentParser::HTMLDocumentParser(HTMLDocument& document, bool reportErrors)
     : ScriptableDocumentParser(document)
     , m_options(&document)
     , m_token(nullptr)
     , m_tokenizer(nullptr)
     , m_scriptRunner(HTMLScriptRunner::create(&document, this))
     , m_treeBuilder(HTMLTreeBuilder::create(this, &document, parserContentPolicy(), reportErrors, m_options))
     , m_parserScheduler(HTMLParserScheduler::create(this))
@@ skipping 600 matching lines @@
 {
     ASSERT(!isStopped());
     ASSERT(shouldUseThreading());
     ASSERT(!m_haveBackgroundParser);
     m_haveBackgroundParser = true;
 
     RefPtr<WeakReference<BackgroundHTMLParser>> reference = WeakReference<BackgroundHTMLParser>::createUnbound();
     m_backgroundParser = WeakPtr<BackgroundHTMLParser>(reference);
 
     // TODO(oysteine): Disabled due to crbug.com/398076 until a full fix can be implemented.
     if (RuntimeEnabledFeatures::threadedParserDataReceiverEnabled()) {

[kouhei (in TOK), 2014/11/18 04:49:55]

I think this is still marked as experimental and not enabled by default.

[oystein (OOO til 10th of July), 2014/11/20 23:24:57]

Yes, I put it behind the flag when we discovered this bug. It should be the only
blocker for the feature.

         if (DocumentLoader* loader = document()->loader())
-            loader->attachThreadedDataReceiver(adoptPtr(new ParserDataReceiver(m_backgroundParser)));
+            loader->attachThreadedDataReceiver(adoptPtr(new ParserDataReceiver(m_backgroundParser, document()->contextDocument())));
     }
 
     OwnPtr<BackgroundHTMLParser::Configuration> config = adoptPtr(new BackgroundHTMLParser::Configuration);
     config->options = m_options;
     config->parser = m_weakFactory.createWeakPtr();
     config->xssAuditor = adoptPtr(new XSSAuditor);
     config->xssAuditor->init(document(), &m_xssAuditorDelegate);
     config->preloadScanner = adoptPtr(new TokenPreloadScanner(document()->url().copy(), createMediaValues(document())));
     config->decoder = takeDecoder();
 
@@ skipping 312 matching lines @@
 void HTMLDocumentParser::setDecoder(PassOwnPtr<TextResourceDecoder> decoder)
 {
     ASSERT(decoder);
     DecodedDataDocumentParser::setDecoder(decoder);
 
     if (m_haveBackgroundParser)
         HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::setDecoder, m_backgroundParser, takeDecoder()));
 }
 
 }