Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 690753009: [WebSocket] Pass received status code of 0 to script as-is (Closed)

Created:
6 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 1 month ago
Reviewers:
Adam Rice
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WebSocket] Pass received status code of 0 to script as-is 0 is not a valid close code, but we're passing through the other invalid codes. Let's apply the rule also to 0 for consistency. R=ricea BUG=428794 Committed: https://crrev.com/ceae3b2476b441367dd75ede1c7781c1094c8ffa Cr-Commit-Position: refs/heads/master@{#302233}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M net/websockets/websocket_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_channel.cc View 1 4 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tyoshino (SeeGerritForStatus)
6 years, 1 month ago (2014-10-30 15:47:34 UTC) #2
tyoshino (SeeGerritForStatus)
Keeping 0 rejected is another choice. I'd like to hear your opinion, Adam-san.
6 years, 1 month ago (2014-10-31 03:18:27 UTC) #3
Adam Rice
LGTM The current behaviour is accidental, let's fix it first of all. I think codes ...
6 years, 1 month ago (2014-10-31 03:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690753009/20001
6 years, 1 month ago (2014-10-31 05:59:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 06:43:26 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 06:44:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ceae3b2476b441367dd75ede1c7781c1094c8ffa
Cr-Commit-Position: refs/heads/master@{#302233}

Powered by Google App Engine
This is Rietveld 408576698