Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 690753003: Crash hard if starting a newly-spawned sub-process fails. (Closed)

Created:
6 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam, jbauman, hendrikw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Crash hard if starting a newly-spawned sub-process fails. This isn't expected to be reached but would help diagnose failures. BUG=424024 R=cpu@chromium.org Committed: https://crrev.com/d5f6af234fdbc8a2ace6e65044e04d7ac99e9c06 Cr-Commit-Position: refs/heads/master@{#302024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/sandbox_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Ken Russell (switch to Gerrit)
Even though this definitely isn't the reason for the sub-process hangs seen in Issue 424024, ...
6 years, 1 month ago (2014-10-30 02:10:48 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-10-30 02:22:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690753003/1
6 years, 1 month ago (2014-10-30 02:22:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 03:09:39 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 03:10:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5f6af234fdbc8a2ace6e65044e04d7ac99e9c06
Cr-Commit-Position: refs/heads/master@{#302024}

Powered by Google App Engine
This is Rietveld 408576698