Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 690743003: Move mojo/bindings/js to mojo/edk/js (Closed)

Created:
6 years, 1 month ago by hansmuller
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Create mojo/edk/js, mojo/edk/js/test Move mojo/bindings/js to mojo/edk/js. Move mojo/bindings/js/tests/run_js_tests.cc into the test directory. Move mojo/apps/js/test/handle_unittest.cc to mojo/edk/js BUG=430520 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1786d35f3d7c6afe5639b354b21f5bc93907253d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1244 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/apps/js/bindings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/gl/context.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/gl/module.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/threading.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/mojo_bridge_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/mojo_runner_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/apps/js/test/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
D mojo/apps/js/test/handle_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M mojo/apps/js/test/run_apps_js_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/bindings/js/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/bindings/js/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/bindings/js/core.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/bindings/js/core.cc View 1 chunk +0 lines, -321 lines 0 comments Download
D mojo/bindings/js/drain_data.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/bindings/js/drain_data.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D mojo/bindings/js/handle.h View 1 chunk +0 lines, -104 lines 0 comments Download
D mojo/bindings/js/handle.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D mojo/bindings/js/handle_close_observer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/bindings/js/support.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/bindings/js/support.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/bindings/js/tests/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/bindings/js/tests/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/bindings/js/tests/run_js_tests.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/bindings/js/waiting_callback.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/bindings/js/waiting_callback.cc View 1 chunk +0 lines, -95 lines 0 comments Download
A + mojo/edk/js/BUILD.gn View 2 chunks +11 lines, -1 line 1 comment Download
A + mojo/edk/js/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/core.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/core.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/edk/js/drain_data.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/drain_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/edk/js/handle.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/handle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/edk/js/handle_close_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/handle_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/edk/js/support.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/support.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/edk/js/tests/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A + mojo/edk/js/tests/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/tests/run_js_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/edk/js/waiting_callback.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/edk/js/waiting_callback.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/viewer/internals.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
Could you update mojo/edk/mojo_edk.gyp ? https://codereview.chromium.org/690743003/diff/1/mojo/edk/js/BUILD.gn File mojo/edk/js/BUILD.gn (right): https://codereview.chromium.org/690743003/diff/1/mojo/edk/js/BUILD.gn#newcode30 mojo/edk/js/BUILD.gn:30: deps = [ nit: ...
6 years, 1 month ago (2014-11-05 23:25:57 UTC) #2
jamesr
lgtm
6 years, 1 month ago (2014-11-05 23:26:03 UTC) #3
hansmuller
6 years, 1 month ago (2014-11-05 23:29:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1786d35f3d7c6afe5639b354b21f5bc93907253d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698