Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5243)

Unified Diff: chrome/browser/history/history_backend.h

Issue 690733002: Cleanup HistoryBackend and ExpireHistoryBackend interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android-cleanup
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index 90cfb6d060735ad921d254a42dc094851a7f7354..6b8ac4c08d9cfd9a66b072c90221aa912f54c9e8 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -99,7 +99,7 @@ class QueuedHistoryDBTask {
// functions in the history service. These functions are not documented
// here, see the history service for behavior.
class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
- public BroadcastNotificationDelegate {
+ public ExpireHistoryBackendDelegate {
public:
// Interface implemented by the owner of the HistoryBackend object. Normally,
// the history service implements this to send stuff back to the main thread.
@@ -795,12 +795,14 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// to be invoked again if there are more tasks that need to run.
void ProcessDBTaskImpl();
- void BroadcastNotifications(int type,
- scoped_ptr<HistoryDetails> details) override;
- void NotifySyncURLsModified(URLRows* rows) override;
- void NotifySyncURLsDeleted(bool all_history,
- bool expired,
- URLRows* rows) override;
+ void BroadcastNotifications(int type, scoped_ptr<HistoryDetails> details);
droger 2014/10/29 17:55:11 Optional: Remove the function? Or add a comment?
sdefresne 2014/10/30 10:54:31 It is still used (but not through ExpireHistoryBac
+
+ // ExpireHistoryBackendDelegate:
+ void NotifyURLsModified(const URLRows& rows) override;
+ void NotifyURLsDeleted(bool all_history,
+ bool expired,
+ const URLRows& rows,
+ const std::set<GURL>& favicon_urls) override;
// Deleting all history ------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698