Cleanup HistoryBackend and ExpireHistoryBackend interface

Cleanup HistoryBackend and ExpireHistoryBackend interface

Rename BroadcastNotificationDelegate to ExpireHistoryBackendDelegate and change
the implementation in HistoryBackend to send the notification as part of the
NotifyURLs{Modified,Deleted} method implementation.

Delete BroadcastNofiticationDelegate::BroadcastNotifications as it is no longer
required.

BUG=373326
Committed: https://crrev.com/be70ea33e45435a034461e3d096c435447e77d9a
Cr-Commit-Position: refs/heads/master@{#302097}

[sdefresne, 2014-10-29 17:30:19]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2014-10-29 17:30:20]

droger: please take a look
brettw: FYI

[droger, 2014-10-29 17:55:11]

lgtm

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend.cc (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:17: #include
"chrome/browser/chrome_notification_types.h"
Is this still needed?

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:19: #include
"chrome/browser/history/history_notifications.h"
Is this still needed?

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend.h (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.h:26: struct HistoryDetails;
Remove.

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend_unittest.cc (left):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend_unittest.cc:150: //
BroadcastNotificationDelegate:
Keep the comment (with an updated name).

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend_unittest.cc (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend_unittest.cc:344:
EXPECT_TRUE(std::find_if(rows.begin(),
Could it be EXPECT_EQ instead?

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/histo...
File chrome/browser/history/history_backend.h (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/histo...
chrome/browser/history/history_backend.h:798: void BroadcastNotifications(int
type, scoped_ptr<HistoryDetails> details);
Optional:
Remove the function?
Or add a comment?

[sdefresne, 2014-10-30 10:54:31]

Thank you for the review.

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend.cc (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:17: #include
"chrome/browser/chrome_notification_types.h"
On 2014/10/29 17:55:11, droger wrote:
> Is this still needed?

No, removed.

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:19: #include
"chrome/browser/history/history_notifications.h"
On 2014/10/29 17:55:11, droger wrote:
> Is this still needed?

No, removed.

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend.h (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.h:26: struct HistoryDetails;
On 2014/10/29 17:55:11, droger wrote:
> Remove.

Done.

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend_unittest.cc (left):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend_unittest.cc:150: //
BroadcastNotificationDelegate:
On 2014/10/29 17:55:11, droger wrote:
> Keep the comment (with an updated name).

Done.

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/histo...
File chrome/browser/history/history_backend.h (right):

https://codereview.chromium.org/690733002/diff/1/chrome/browser/history/histo...
chrome/browser/history/history_backend.h:798: void BroadcastNotifications(int
type, scoped_ptr<HistoryDetails> details);
On 2014/10/29 17:55:11, droger wrote:
> Optional:
> Remove the function?
> Or add a comment?

It is still used (but not through ExpireHistoryBackendDelegate), adding a
comment.

[sdefresne, 2014-10-30 16:42:04]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-10-30 16:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690733002/20001

[commit-bot: I haz the power, 2014-10-30 17:38:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-30 17:39:26]

Patchset 2 (id:??) landed as
https://crrev.com/be70ea33e45435a034461e3d096c435447e77d9a
Cr-Commit-Position: refs/heads/master@{#302097}