Chromecast: removes devtools resources from bundle.

Chromecast: removes devtools resources from bundle.

The devtools discovery page is rewritten/cleaned up to support two
optional paths for users:
1) Use the remote AppEngine debugger, which connects over WebSockets
   to the device. This triggers a security warning, so a help link
   is added for the user.
2) Provide a link to the Chrome native devtools UI for users.

R=byungchul@chromium.org,lcwu@chromium.org,dgozman@chromium.org
BUG=428471
Committed: https://crrev.com/31e90adac9fd24f1b451bbe936406fbc0fe7345d
Cr-Commit-Position: refs/heads/master@{#302013}

[byungchul, 2014-10-29 21:35:53]

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
File chromecast/app/resources/shell_devtools_discovery_page.html (right):

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:22: <script>
move script after body to faster loading.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:41:
item_container.appendChild(frontend_link);
I think it would be better to append child after completing filling the content.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:43: var
is_debuggable = Boolean(metadata.devtoolsFrontendUrl);
!!metadata.devtoolsFrontendUrl?

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:45: if
(metadata.devtoolsFrontendUrl) {
is_debuggable

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:51: 'You may have to
select the shield icon in the address bar to ' +
This is true only for chrome. Explorer might not have this feature, and firefox
might have the icon in different place?

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:70:
item_container.appendChild(local_ui_link);
Why don't you put these div's in the body and control display?

[dgozman, 2014-10-29 22:40:14]

devtools lgtm

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
File chromecast/app/resources/shell_devtools_discovery_page.html (right):

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:65:
local_ui_link.value = metadata.devtoolsFrontendUrl.replace(
This is actually not a local ui - it still fetches frontend from appspot, but
via different scheme, which allows insecure web sockets.

[gunsch, 2014-10-29 23:01:37]

Patchset #3 (id:40001) has been deleted

[gunsch, 2014-10-29 23:02:00]

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
File chromecast/app/resources/shell_devtools_discovery_page.html (right):

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:22: <script>
On 2014/10/29 21:35:52, byungchul wrote:
> move script after body to faster loading.

Ha, it's literally loading 2 kilobytes over your local network :) but sure, why
not.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:41:
item_container.appendChild(frontend_link);
On 2014/10/29 21:35:53, byungchul wrote:
> I think it would be better to append child after completing filling the
content.

That would be an incorrect functionality change: item_container might get more
items appended to it within the conditions below.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:43: var
is_debuggable = Boolean(metadata.devtoolsFrontendUrl);
On 2014/10/29 21:35:53, byungchul wrote:
> !!metadata.devtoolsFrontendUrl?

Done.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:45: if
(metadata.devtoolsFrontendUrl) {
On 2014/10/29 21:35:52, byungchul wrote:
> is_debuggable

Done.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:51: 'You may have to
select the shield icon in the address bar to ' +
On 2014/10/29 21:35:53, byungchul wrote:
> This is true only for chrome. Explorer might not have this feature, and
firefox
> might have the icon in different place?

DevRel confirmed this isn't a concern, and that we already expect developers to
be using Chrome.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:65:
local_ui_link.value = metadata.devtoolsFrontendUrl.replace(
On 2014/10/29 22:40:14, dgozman wrote:
> This is actually not a local ui - it still fetches frontend from appspot, but
> via different scheme, which allows insecure web sockets.

Done.

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:70:
item_container.appendChild(local_ui_link);
On 2014/10/29 21:35:52, byungchul wrote:
> Why don't you put these div's in the body and control display?

We could have multiple items in the list, if we're hosting multiple WebContents
for example. So creating them on the fly is important.

[byungchul, 2014-10-29 23:19:16]

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
File chromecast/app/resources/shell_devtools_discovery_page.html (right):

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:70:
item_container.appendChild(local_ui_link);
On 2014/10/29 23:02:00, gunsch wrote:
> On 2014/10/29 21:35:52, byungchul wrote:
> > Why don't you put these div's in the body and control display?
> 
> We could have multiple items in the list, if we're hosting multiple
WebContents
> for example. So creating them on the fly is important.

At least, help texts can be static.

[gunsch, 2014-10-30 00:44:32]

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
File chromecast/app/resources/shell_devtools_discovery_page.html (right):

https://codereview.chromium.org/690723005/diff/20001/chromecast/app/resources...
chromecast/app/resources/shell_devtools_discovery_page.html:70:
item_container.appendChild(local_ui_link);
On 2014/10/29 23:19:16, byungchul wrote:
> On 2014/10/29 23:02:00, gunsch wrote:
> > On 2014/10/29 21:35:52, byungchul wrote:
> > > Why don't you put these div's in the body and control display?
> > 
> > We could have multiple items in the list, if we're hosting multiple
> WebContents
> > for example. So creating them on the fly is important.
> 
> At least, help texts can be static.

Done.

[byungchul, 2014-10-30 00:51:34]

lgtm

[gunsch, 2014-10-30 01:02:22]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-10-30 01:03:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690723005/80001

[commit-bot: I haz the power, 2014-10-30 01:47:19]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-10-30 01:48:03]

Patchset 4 (id:??) landed as
https://crrev.com/31e90adac9fd24f1b451bbe936406fbc0fe7345d
Cr-Commit-Position: refs/heads/master@{#302013}