Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: sync/internal_api/attachments/proto/attachment_store.proto

Issue 690723004: Add per attachment metadata records. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes after feedback. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/proto/attachment_store.proto
diff --git a/sync/internal_api/attachments/proto/attachment_store.proto b/sync/internal_api/attachments/proto/attachment_store.proto
index 533332d5d011417ff241c0e86d97803319c4fb30..3b6b41cd1f0e028406831e75e4016a33426ed075 100644
--- a/sync/internal_api/attachments/proto/attachment_store.proto
+++ b/sync/internal_api/attachments/proto/attachment_store.proto
@@ -10,9 +10,18 @@ option retain_unknown_fields = true;
package attachment_store_pb;
// Metadata for leveldb attachment store database.
-message AttachmentStoreMetadata {
+message StoreMetadata {
// |schema_version| indicates format in which data is written in attachment
// store. Needed for upgrade and to prevent newer data from being loaded by
// older code that doesn't understand it.
optional int32 schema_version = 1;
}
+
+// Metadata for attachment in attachemnt store. Storing metadata in separate
stanisc 2014/10/30 18:56:59 Nit: typo - attachemnt
pavely 2014/10/30 19:54:15 Done.
+// record from actual data allows us to enumerate attachments in the store
+// without incurring cost to read actual data. It also allows us to update
+// attachment metadata independent of the data.
+message RecordMetadata {
+ // Size of attachment data. Useful for attachment store space management.
+ optional int64 attachment_size = 1;
+}

Powered by Google App Engine
This is Rietveld 408576698