Add per attachment metadata records.

sync/internal_api/public/attachments/on_disk_attachment_store.h

Index: sync/internal_api/public/attachments/on_disk_attachment_store.h
diff --git a/sync/internal_api/public/attachments/on_disk_attachment_store.h b/sync/internal_api/public/attachments/on_disk_attachment_store.h
index 51e5dabea9ce3a5e768f7073210e180622e059f2..e8d60962bd65b8373e0a0ec0d9cd59109eebc578 100644
--- a/sync/internal_api/public/attachments/on_disk_attachment_store.h
+++ b/sync/internal_api/public/attachments/on_disk_attachment_store.h
@@ -47,7 +47,18 @@ class SYNC_EXPORT OnDiskAttachmentStore : public AttachmentStoreBase,
   Result OpenOrCreate(const base::FilePath& path);
 
  private:
-  std::string MakeDataKeyFromAttachmentId(const AttachmentId& attachment_id);
+  friend class OnDiskAttachmentStoreSpecificTest;

[maniscalco, 2014/10/30 16:40:20]

Would FRIEND_TEST_ALL_PREFIXES work here? 

[pavely, 2014/10/30 18:28:36]

FRIEND_TEST_ALL_PREFIXES is for befriending individual tests:
  FRIEND_TEST_ALL_PREFIXES(OnDiskAttachmentStoreSpecificTest,
AttachmentRecordMetadata)

In this case I put helper function into test case class and want it to have
access to OnDiskAttachmentStore.

[maniscalco, 2014/10/30 18:33:10]

I see.

+
+  // Reads single attachment from store. Returns nullptr in case of errors.
+  scoped_ptr<Attachment> ReadSingleAttachment(
+      const AttachmentId& attachment_id);
+  // Writes single attachment to store. Returns false in case of errors.
+  bool WriteSingleAttachment(const Attachment& attachment);
+
+  static std::string MakeDataKeyFromAttachmentId(
+      const AttachmentId& attachment_id);
+  static std::string MakeMetadataKeyFromAttachmentId(
+      const AttachmentId& attachment_id);
 
   scoped_refptr<base::SequencedTaskRunner> callback_task_runner_;
   scoped_ptr<leveldb::DB> db_;